Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website minor fix link and formatting #1708

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Website minor fix link and formatting #1708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6f0398
Fix link on a website
aLekSer Jul 21, 2020
0478104
Adding some missing dots.
aLekSer Jul 21, 2020
fe2db94
Merge branch 'master' into website/fix-link
aLekSer Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ Have a look in the [examples](../examples) folder to see examples of running Gam
## Make Variable Reference

### VERSION
The version of this build. Version defaults to the short hash of the latest commit
The version of this build. Version defaults to the short hash of the latest commit.

### REGISTRY
The registry that is being used to store docker images. Defaults to gcr.io/agones-images - the release + CI registry.
Expand All @@ -380,7 +380,7 @@ The registry that is being used to store docker images. Defaults to gcr.io/agone
The Kubernetes config file used to access the cluster. Defaults to `~/.kube/config` - the file used by default by kubectl.

### CLUSTER_NAME
The (gcloud) test cluster that is being worked against. Defaults to `test-cluster`
The (gcloud) test cluster that is being worked against. Defaults to `test-cluster`.

### GCP_PROJECT
Your GCP project for deploying GKE cluster. Defaults to gcloud default project settings.
Expand All @@ -405,7 +405,7 @@ All targets will create the build image if it is not present.

### Development Targets

Targets for developing with the build image
Targets for developing with the build image.

#### `make build`
Build all the images required for Agones, as well as the SDKs
Expand Down
2 changes: 1 addition & 1 deletion site/content/en/docs/FAQ/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ We routinely see users running container images that are multiple GB in size.
The only downside to larger images, is that they can take longer to first load on a Kubernetes node, but that can be
managed by your
[Fleet]({{< ref "/docs/Reference/fleet.md" >}}) and
[Fleet Autoscaling]({{< ref "/docs/Reference/fleetautoscaler.md" >}}
[Fleet Autoscaling]({{< ref "/docs/Reference/fleetautoscaler.md" >}})
configuration to ensure this load time is taken into account on a new Node's container initial load.

### How quickly can Agones spin up new GameServer instances?
Expand Down
4 changes: 2 additions & 2 deletions site/content/en/docs/Guides/Client SDKs/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ You can use `SDKWatchSendOnExecute` feature passed as a [feature gate]({{< ref "
#### SetLabel(key, value)

This will set a [Label](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/) value on the backing `GameServer`
record that is stored in Kubernetes. To maintain isolation, the `key` value is automatically prefixed with "agones.dev/sdk-"
record that is stored in Kubernetes. To maintain isolation, the `key` value is automatically prefixed with "agones.dev/sdk-".

{{< alert title="Warning" color="warning">}}
There are limits on the characters that be used for label keys and values. Details are [here](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set).
Expand All @@ -182,7 +182,7 @@ This can be useful if you want information from your running game server process
#### SetAnnotation(key, value)

This will set a [Annotation](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) value on the backing
`Gameserver` record that is stored in Kubernetes. To maintain isolation, the `key` value is automatically prefixed with "agones.dev/sdk-"
`GameServer` record that is stored in Kubernetes. To maintain isolation, the `key` value is automatically prefixed with "agones.dev/sdk-".

This can be useful if you want information from your running game server process to be observable through the Kubernetes API.

Expand Down