-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fleetautoscalers webhook TLS policy #1736
Conversation
There was an issue with not setting RootCA certs.
@aLekSer thank you for taking a look at this so quickly! |
Build Failed 😱 Build Id: 4fac3b91-ce3d-4375-949f-ff9908b853d6 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Error connected with
|
Tested locally:
|
Build Succeeded 👏 Build Id: 40f27c77-f4bc-4c3c-a512-dad0894570b0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the issue now! Good find!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: eb986f04-02ab-4c87-a9e0-d475977ae4a1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was an issue with not setting RootCA certs. Co-authored-by: Mark Mandel <markmandel@google.com>
There was an issue with not setting RootCA certs.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #1734
Special notes for your reviewer:
We don't need
SystemRootCA
as we want to allow only one CertificateAuthority to sign clients certificates forFleetAutoscalers
Webhooks
.In the future we could add mTLS support.