Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fleetautoscalers webhook TLS policy #1736

Merged
merged 3 commits into from
Aug 6, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Aug 4, 2020

There was an issue with not setting RootCA certs.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

What this PR does / Why we need it:

Which issue(s) this PR fixes:
Closes #1734

Special notes for your reviewer:
We don't need SystemRootCA as we want to allow only one CertificateAuthority to sign clients certificates for FleetAutoscalers Webhooks.
In the future we could add mTLS support.

There was an issue with not setting RootCA certs.
@rorygarand
Copy link
Contributor

@aLekSer thank you for taking a look at this so quickly!

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4fac3b91-ce3d-4375-949f-ff9908b853d6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator Author

aLekSer commented Aug 4, 2020

Error connected with hugo bug :

	"RELEASE_VERSION=1.8.0 RELEASE_BRANCH=master hugo --config=config.toml -F"
fatal error: concurrent map read and map write

goroutine 238 [running]:
runtime.throw(0x1e2fd5a, 0x21)
	/usr/local/go/src/runtime/panic.go:1116 +0x72 fp=0xc001fe8878 sp=0xc001fe8848 pc=0x4f1712
runtime.mapaccess1_faststr(0x1b27300, 0xc000c63650, 0xc000cc67e2, 0x1c, 0x23691c0)

@aLekSer
Copy link
Collaborator Author

aLekSer commented Aug 4, 2020

Tested locally:

  ----     ------            ----                ----                        -------
  Warning  FailedGetFleet    69s (x3 over 117s)  fleetautoscaler-controller  could not fetch fleet: simple-udp
  Normal   AutoScalingFleet  9s                  fleetautoscaler-controller  Scaling fleet simple-udp from 2 to 4
by-it00060:crt23 alexander$ kubectl describe fleetautoscaler

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 40f27c77-f4bc-4c3c-a512-dad0894570b0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1736/head:pr_1736 && git checkout pr_1736
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-2e606d4

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the issue now! Good find!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@markmandel markmandel added this to the 1.8.0 milestone Aug 6, 2020
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. labels Aug 6, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: eb986f04-02ab-4c87-a9e0-d475977ae4a1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1736/head:pr_1736 && git checkout pr_1736
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-79e5bd5

@markmandel markmandel merged commit f2ee5ac into googleforgames:master Aug 6, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
There was an issue with not setting RootCA certs.

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/bug These are bugs. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quickstart: create webhook autoscaler not working
6 participants