Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GKE Terraform clusters to 1.16 #1772

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This includes upgrade for:

  • Agones Development GKE cluster
  • e2e GKE test clusters
  • Terraform GKE user cluster

Which issue(s) this PR fixes:

Work on #1649

Special notes for your reviewer:

Also fixes issue on upgrade of a cluster, in that the nodepools are now upgraded as well.

Removed the kubernetes version from the dev cluster variables, as it wasn't being used, and made updating to the new version more complex.

I've run a few e2e tests against the 1.16 cluster with no issue. Once this approved and merged, I'll update the e2e cluster.

This includes upgrade for:
- Agones Development GKE cluster
- e2e GKE test clusters
- Terraform GKE user cluster

Also fixes issue on upgrade of a cluster, in that the nodepools are
now upgraded as well.

Removed the kubernetes version from the dev cluster variables, as it
wasn't being used, and made updating to the new version more complex.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0eec81a8-8e2e-4706-88b6-0aff79255d98

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1772/head:pr_1772 && git checkout pr_1772
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-b4e52e5

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 247aaaf into googleforgames:master Aug 26, 2020
@markmandel markmandel deleted the upgrade/gke-1.16 branch August 26, 2020 16:22
@markmandel markmandel added this to the 1.9.0 milestone Aug 26, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
This includes upgrade for:
- Agones Development GKE cluster
- e2e GKE test clusters
- Terraform GKE user cluster

Also fixes issue on upgrade of a cluster, in that the nodepools are
now upgraded as well.

Removed the kubernetes version from the dev cluster variables, as it
wasn't being used, and made updating to the new version more complex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc cla: yes kind/breaking Breaking change lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants