Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GolangCI-lint updating version to 1.30 #1785

Merged
merged 3 commits into from
Sep 3, 2020
Merged

GolangCI-lint updating version to 1.30 #1785

merged 3 commits into from
Sep 3, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Sep 3, 2020

Add exportloopref which is a successor of obsoleted scopelint.
Disable unnecessaryDefer which are located right before return.

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

Updating Golangci-lint version and added a successor of scopelint which is obsolete.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@aLekSer
GolangCI-lint updating version to 1.30
271255f 
Add exportloopref which is a successor of obsoleted scopelint.
Disable unnecessaryDefer which are located right before return.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a3760ecf-6989-4a18-bafd-0b0e550958ed

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1785/head:pr_1785 && git checkout pr_1785
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-271255f

@aLekSer aLekSer added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Sep 3, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dfb98e91-bcf0-4535-9427-2bc3510a3123

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1785/head:pr_1785 && git checkout pr_1785
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-4cad758

markmandel
markmandel approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f7a5693a-aa41-4f53-bc7e-a9b6f26475fa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1785/head:pr_1785 && git checkout pr_1785
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-7aa3f7c

@markmandel markmandel merged commit 42776b6 into googleforgames:master Sep 3, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 3, 2020
@aLekSer aLekSer deleted the updating-golangci-lint branch September 4, 2020 09:15
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @markmandel @ilkercelikyilmaz
GolangCI-lint updating version to 1.30 (googleforgames#1785)
6055fd4 
Add exportloopref which is a successor of obsoleted scopelint.
Disable unnecessaryDefer which are located right before return.

Co-authored-by: Mark Mandel <markmandel@google.com>
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @markmandel @ilkercelikyilmaz
GolangCI-lint updating version to 1.30 (googleforgames#1785)
70a9483 
Add exportloopref which is a successor of obsoleted scopelint.
Disable unnecessaryDefer which are located right before return.

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@markmandel markmandel

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes size/S
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @google-oss-robot @markmandel @googlebot