Windows eol #182
Windows eol #182
Conversation
fooock
force-pushed
the
bugfix/windows-line-endings
branch
from
bd26044
to
260f3e1
Compare
|
Build Succeeded 👏 Build Id: 939a95e0-5002-458c-933f-f1183e35beed The following development artifacts have been built, and will exist for the next 30 days:
|
|
Build Succeeded 👏 Build Id: 254dc1a5-3edc-4062-9976-edfd45bf5926 The following development artifacts have been built, and will exist for the next 30 days:
|
.gitattributes
Outdated
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
There was a problem hiding this comment.
Let's add a a reference to golang/go#9281, as it has a helpful discussion of what the following line means and why we want it.
.gitattributes
Outdated
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| * -text |
There was a problem hiding this comment.
Please add a newline to the file. Editors typically do this by default, but sometimes you have to configure it. If you're using IntelliJ, see "Settings → Editor → General → Ensure line feed at file end on Save".
| go get -u golang.org/x/tools/cmd/stringer | ||
|
|
||
| .PHONY: default generate test updatedeps | ||
| TEST?=./... |
There was a problem hiding this comment.
Will you revert this change? It's unrelated to the PR.
fooock
force-pushed
the
bugfix/windows-line-endings
branch
from
260f3e1
to
7da7f87
Compare
|
Build Succeeded 👏 Build Id: 37ba2c86-c5ad-4157-99b0-6ab9616dfbc7 The following development artifacts have been built, and will exist for the next 30 days:
|
…e endings. Based on work in golang.org/issue/9281
fooock
force-pushed
the
bugfix/windows-line-endings
branch
from
7da7f87
to
7d9c318
Compare
|
Build Succeeded 👏 Build Id: 7da7a615-f339-4bb1-aa38-2ab6edec2d16 The following development artifacts have been built, and will exist for the next 30 days:
|
markmandel
added
kind/cleanup
Treat all files in the repo as binary, with no git magic updating line endings. Based on work in golang.org/issue/9281