Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected gke docs 'release-release' typo #1826

Merged

Conversation

eddie-knight
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

A small typo existed in an installation step, so this PR corrects for that.

The current text is as follows:

For example, if you are targeting release release-1.8.0, then you will want to have source = "git::https://github.com/googleforgames/agones.git//install/terraform/modules/gke/?ref=release-release-1.8.0" as your source.

This should instead say ?ref=release-1.8.0.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0d7717e1-085e-4b0e-b4d9-e048b1888441

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddie-knight, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c38eb230-0686-4fe8-acf7-8245fd8d9511

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

Flake in unrelated tests:

--- FAIL: TestFleetScaleUpEditAndScaleDown (0.03s)
    --- FAIL: TestFleetScaleUpEditAndScaleDown/Use_fleet_Patch_false (362.96s)
        fleet_test.go:192: 
            	Error Trace:	fleet_test.go:192
            	Error:      	Expected nil, but got: &errors.errorString{s:"timed out waiting for the condition"}
            	Test:       	TestFleetScaleUpEditAndScaleDown/Use_fleet_Patch_false

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5667d0c0-1eec-4853-9efb-17f206feaede

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1826/head:pr_1826 && git checkout pr_1826
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-94e3bf1

@roberthbailey roberthbailey merged commit b62d100 into googleforgames:master Sep 20, 2020
@eddie-knight eddie-knight deleted the docs/release-typofix branch September 22, 2020 14:30
@markmandel markmandel added this to the 1.9.0 milestone Sep 22, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Sep 22, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants