Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Make commands from Metrics documentation #1858

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Users shouldn't be seeing the internal development tooling, so I removed the references to build/ Make commands from the metrics setup and usage documentation.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Users shouldn't be seeing the internal development tooling, so I removed
the references to `build/` Make commands from the metrics setup and
usage documentation.
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Oct 20, 2020
@google-cla google-cla bot added the cla: yes label Oct 20, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 01068cf0-7543-41bb-931d-d4800b97d2e1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1858/head:pr_1858 && git checkout pr_1858
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-f0cc74c

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ce11bfc0-c9fc-4ba5-81c3-0dc9cf4eb16b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1858/head:pr_1858 && git checkout pr_1858
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-fb08528

@markmandel markmandel merged commit 7cc4cec into googleforgames:master Oct 21, 2020
@markmandel markmandel deleted the docs/remove-metrics-make branch October 21, 2020 01:44
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Users shouldn't be seeing the internal development tooling, so I removed
the references to `build/` Make commands from the metrics setup and
usage documentation.
@markmandel markmandel added this to the 1.10.0 milestone Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants