Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1854: Fix getplayercount() description on index #1912

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Issue #1854: Fix getplayercount() description on index #1912

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8228776
Fix Getplayercount discription to match the rest api
NomadicBits Nov 29, 2020
3732745
Update Guides/ClientSDKS/index GetPlayerCount() add alert back in
NomadicBits Dec 2, 2020
f1747b5
Merge branch 'master' into doucmentation/getplayercount
markmandel Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions site/content/en/docs/Guides/Client SDKs/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,9 @@ If `GameServer.Status.Players.Capacity` is set manually through the Kubernetes A

#### Alpha().GetPlayerCount()

This function returns if the playerID is currently connected to the GameServer.
This is always accurate from what has been set through this SDK,
even if the value has yet to be updated on the GameServer status resource.
This function retrieves the current player count.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this through!

We should keep the note about "If GameServer.Status.Players.IDs is set manually through the Kubernetes API..." because it is still relevant (and important too 😄)

This is always accurate from what has been set through this SDK, even if the value has yet to be updated on the
GameServer status resource.

{{< alert title="Note" color="info">}}
If `GameServer.Status.Players.IDs` is set manually through the Kubernetes API, use SDK.GameServer()
Expand Down