Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated terraform scripts to 1.17 #1916

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Updating K8s version.

Which issue(s) this PR fixes:

Work on #1824

Special notes for your reviewer:

N/A

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/breaking Breaking change area/operations Installation, updating, metrics etc labels Dec 7, 2020
@google-cla google-cla bot added the cla: yes label Dec 7, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f3a5c5b3-4b82-4a0d-979e-1b3c690e0486

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1916/head:pr_1916 && git checkout pr_1916
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-6e91a2e

@@ -60,7 +60,7 @@ resource "azurerm_kubernetes_cluster" "agones" {
resource_group_name = azurerm_resource_group.agones_rg.name
dns_prefix = "agones"

kubernetes_version = "1.16.13"
kubernetes_version = "1.17.13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using sudo docker run -it mcr.microsoft.com/azure-cli I verified that this minor version is available:

bash-5.0# az aks get-versions --location eastus --output table
KubernetesVersion    Upgrades
-------------------  -------------------------
1.19.3               None available
1.19.1               1.19.3
1.18.10              1.19.1, 1.19.3
1.18.8               1.18.10, 1.19.1, 1.19.3
1.17.13              1.18.8, 1.18.10
1.17.11              1.17.13, 1.18.8, 1.18.10
1.16.15              1.17.11, 1.17.13
1.16.13              1.16.15, 1.17.11, 1.17.13

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked our last community meeting notes where you did the same 😄 but thanks for the confirm!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 2a9cece into googleforgames:master Dec 8, 2020
@markmandel markmandel added this to the 1.11.0 milestone Dec 8, 2020
@markmandel markmandel deleted the cleanup/tf-1.17 branch December 8, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc cla: yes kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants