Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeSelector property to Agones helm chart for Allocator #1946

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Add nodeSelector property to Agones helm chart for Allocator #1946

merged 3 commits into from
Jan 13, 2021

Conversation

yeslayla
Copy link
Contributor

What type of PR is this?
I would think
/kind feature

What this PR does / Why we need it:
When trying to deploy to a cluster with both Linux and Windows containers, Agones needs to be configurable to just select the Linux nodes. The easiest way to do so is with a nodeSelector.

@google-cla
Copy link

google-cla bot commented Jan 12, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 12, 2021
@yeslayla yeslayla changed the title Add nodeSelector property to Agones helm chart Add nodeSelector property to Agones helm chart for Allocator Jan 12, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 12, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9acc04f5-c607-4110-94f7-4d5b50c8d4e6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e042d5f3-8a3e-4fdb-be73-e824c6f35851

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 55abef85-dae5-4e58-bfad-5daa98e1cf5a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1946/head:pr_1946 && git checkout pr_1946
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-88e0238

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephbmanley, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b47400f5-285a-4724-9288-71a349d49296

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1946/head:pr_1946 && git checkout pr_1946
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-bd3372d

@markmandel markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Jan 13, 2021
@markmandel markmandel added this to the 1.12.0 milestone Jan 13, 2021
@markmandel markmandel merged commit 92454b4 into googleforgames:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc cla: yes kind/feature New features for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants