Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored sdk functions to always return &alpha.Bool{} instead of nil #1958

Conversation

justjoeyuk
Copy link
Contributor

@justjoeyuk justjoeyuk commented Jan 20, 2021

What type of PR is this?

/kind bug

What this PR does / Why we need it:
This PR fixes the issue presented in #1957 wherein the SDK returns a nil value for an ok value instead of an alpha.Bool{ Bool: false }. This PR ensures that the SDK always returns a value for ok and that users can expect an ok value to always be non-nil.

Which issue(s) this PR fixes:
Work on #1957

Special notes for your reviewer:
This is my first contribution - so I may have made a few errors of judgement in places. I'm happy to hear feedback and make the relevant changes.

@google-cla
Copy link

google-cla bot commented Jan 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1f1b0dbd-2b59-481b-a833-12a2d508e521

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@justjoeyuk justjoeyuk force-pushed the bug/1957-player-connect-capacity-panic branch from e0e60b2 to eec8942 Compare January 20, 2021 22:08
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1750ee46-67f9-4c88-b1ec-93a5b9c42947

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1958/head:pr_1958 && git checkout pr_1958
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-eec8942

@markmandel
Copy link
Member

Thanks for this!

Can we switch Closes #1957 to Work on #1957?

This is a great first start, but we'll likely also want at least an e2e test to confirm that this actually closes the bug in question, so we won't want to close the issue until that is done.

Unless you want to add an e2e test to this PR, or we can have it happen in a separate PR, either way is totally fine 👍

@markmandel
Copy link
Member

Can we switch Closes #1957 to Work on #1957?

If you are happy with it, I can make this change via GitHub (forgot I can do this) - if we want to push this through before RC next week.

But wanted to ask permission first before messing with your PR.

Let me know!

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justjoeyuk, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added the kind/bug These are bugs. label Jan 25, 2021
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 128a09cf-07ff-4d3e-8853-dd7385d2b2ea

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1958/head:pr_1958 && git checkout pr_1958
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-443e54e

@markmandel markmandel merged commit 676a065 into googleforgames:master Jan 25, 2021
@markmandel markmandel added this to the 1.12.0 milestone Jan 25, 2021
@markmandel markmandel added the area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/bug These are bugs. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants