Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SDKWatchSendOnExecute to Beta stage. #1960

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Move SDKWatchSendOnExecute to Beta stage. #1960

merged 1 commit into from
Jan 24, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Switch SDKWatchSendOnExecute to true by default, and update the documentation and testing.

Which issue(s) this PR fixes:

Closes #1904

Special notes for your reviewer:

@markmandel markmandel added kind/feature New features for Agones kind/breaking Breaking change labels Jan 22, 2021
@google-cla google-cla bot added the cla: yes label Jan 22, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1bde2c8d-8f0d-47e0-abb6-ac5e1a32193b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1960/head:pr_1960 && git checkout pr_1960
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-c696bdf

roberthbailey
roberthbailey reviewed Jan 22, 2021
View reviewed changes
site/content/en/docs/Guides/feature-stages.md Outdated
| Example Gate (not in use) | `Example` | Disabled | None | 0.13.0 |
| [Port Allocations to Multiple Containers]({{< ref "/docs/Reference/gameserver.md" >}}) | `ContainerPortAllocation` | Enabled | `Beta` | 1.7.0 |
| [Player Tracking]({{< ref "/docs/Guides/player-tracking.md" >}}) | `PlayerTracking` | Disabled | `Alpha` | 1.6.0 |
| [SDK Send GameServer on Watch execution]({{< ref "/docs/Guides/Client SDKs/_index.md#watchgameserverfunctiongameserver" >}}) | `SDKWatchSendOnExecute` | Disabled | `Beta` | 1.12.0 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In pkg/util/runtime/features.go you changed the default to true, so this should say "Enabled" (or we should leave the default as disabled).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻 Good catch! Will fix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..and done!

@markmandel
Move SDKWatchSendOnExecute to Beta stage.
19c7c54 
Switch `SDKWatchSendOnExecute` to true by default, and update the
documentation and testing.

Closes googleforgames#1904
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1eb9130f-46f9-45b2-aeae-de7c31823eb9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1960/head:pr_1960 && git checkout pr_1960
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-19c7c54

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 086f8b9 into googleforgames:master Jan 24, 2021
@markmandel markmandel deleted the beta/SDKWatchSendOnExecute branch January 24, 2021 18:58
@markmandel markmandel added this to the 1.12.0 milestone Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved cla: yes kind/breaking Breaking change kind/feature New features for Agones lgtm size/S
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Move SDKWatchSendOnExecute to Beta
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey