Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the disableTLS to only gRPC API #1968

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Limit the disableTLS to only gRPC API #1968

merged 3 commits into from
Jan 29, 2021

Conversation

pooneh-m
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / Why we need it:

When REST API was introduced to agones-allocator in Agones v1.11, the disableTLS helm flag stopped working. This is a documentation update to let users know that gRPC API is incompatible with the disableTLS flag until the issue is resolved.

Which issue(s) this PR fixes:

Issue #1945

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: eeca5eac-30bd-4131-9ca9-4cfb4d712611

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1968/head:pr_1968 && git checkout pr_1968
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-3fb9057

Co-authored-by: Mark Mandel <markmandel@google.com>
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 54feaac0-ffff-4e88-a887-c6a8f0aac442

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Jan 29, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9e621767-5d12-424b-96b3-06a4f5adce45

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1968/head:pr_1968 && git checkout pr_1968
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-91a130c

@markmandel markmandel merged commit 5097128 into master Jan 29, 2021
@markmandel markmandel added this to the 1.12.0 milestone Jan 29, 2021
@markmandel markmandel deleted the pooneh-m-patch-1 branch January 29, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants