Terraform helm module fix deprecated version declaration

[comerford]

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:

This switches the helm terraform provider over to a required_providers block rather than the deprecated method of putting a version into the provider block. This should be done in the AKS/EKS modules too. Also adds a minimum version to terraform (this is in line with other modules). The source line in the block will cause 0.12 and lower to carp, but it will ignore the extra line. 0.13 and above will use it appropriately.

Special notes for your reviewer:

I could probably do the same changes for the EKS/AKS modules but I don't have any way to actually test it at present

[agones-bot]

Build Succeeded 👏

Build Id: 4bfd96d9-350f-49fb-9e89-f7e9dffe2656

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.13.0-63a8b0c
• image: gcr.io/agones-images/agones-sdk:1.13.0-63a8b0c
• image: gcr.io/agones-images/agones-ping:1.13.0-63a8b0c
• Linux C++ SDK (build): agonessdk-1.13.0-63a8b0c-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.13.0-63a8b0c.zip

A preview of the website (the last 30 builds are retained):

• https://63a8b0c-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1994/head:pr_1994 && git checkout pr_1994
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-63a8b0c

[markmandel]

The source line in the block will cause 0.12 and lower to carp, but it will ignore the extra line. 0.13 and above will use it appropriately.

Thanks for doing this work! Just to confirm, because I wasn't quite sure from the comment. Will this stop TF 0.12 from working at all? Or will it still work, but show a message?

[comerford]

0.12.6 and above (with the version constraint on terraform itself) will still work (have tested this) - it just prints a warning about ignoring the source lines in the config. If you don't have source lines you get worse issues with 0.13 and above.

…

On Fri, Feb 12, 2021 at 11:06 PM Mark Mandel ***@***.***> wrote: The source line in the block will cause 0.12 and lower to carp, but it will ignore the extra line. 0.13 and above will use it appropriately. Thanks for doing this work! Just to confirm, because I wasn't quite sure from the comment. Will this stop TF 0.12 from working at all? Or will it still work, but show a message? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1994 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADMW7CKQSU2HHPYDH4AQWTS6WX5NANCNFSM4XP4N4OA> .

-- https://comerford.net

[markmandel]

Perfect! Thanks for the clarification 👍🏻

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: comerford, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agones-bot]

Build Succeeded 👏

Build Id: 906e6c43-954c-4e80-8996-4128507e008b

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.13.0-c0ec96c
• image: gcr.io/agones-images/agones-sdk:1.13.0-c0ec96c
• image: gcr.io/agones-images/agones-ping:1.13.0-c0ec96c
• Linux C++ SDK (build): agonessdk-1.13.0-c0ec96c-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.13.0-c0ec96c.zip

A preview of the website (the last 30 builds are retained):

• https://c0ec96c-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1994/head:pr_1994 && git checkout pr_1994
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-c0ec96c