Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce e2e test parrallelism from 64 to 32 #2019

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Reduce e2e test parrallelism from 64 to 32 #2019

merged 1 commit into from
Mar 9, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

One theory is that we're running too many tests for the controller/control plane to manage at any given point and time, and things are timing out, and that's why we're getting so many flakes.

Which issue(s) this PR fixes:

Closes #2016

Special notes for your reviewer:

N/A

@markmandel
Reduce e2e test parrallelism from 64 to 32
5a46d6e 
One theory is that we're running too many tests
for the controller/control plane to manage at any given
point and time, and things are timeing out.
@markmandel markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Mar 8, 2021
@google-cla google-cla bot added the cla: yes label Mar 8, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6f021aea-3461-47c4-8b64-0cdf465faffd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2019/head:pr_2019 && git checkout pr_2019
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-5a46d6e

@markmandel
Copy link
Member Author

To note - still took 00:20:43, which is about the time a passing system takes now.

roberthbailey
roberthbailey approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this succeeded on the first try and other PRs have had lots of failures, should we merge this and see if it helps?

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c2bd1326-3831-42b0-8c33-8fe339a61efe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2019/head:pr_2019 && git checkout pr_2019
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-5a46d6e

@markmandel
Copy link
Member Author

🤞 third time is the charm, so please, please, please work.

@markmandel
Copy link
Member Author

Given that this succeeded on the first try and other PRs have had lots of failures, should we merge this and see if it helps?

Two times though. I'm going to give it one more spin, and if that goes through, I'm definitely down to merge it.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a31577d7-c754-409b-bd71-847e2472bf24

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2019/head:pr_2019 && git checkout pr_2019
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-5a46d6e

@markmandel markmandel marked this pull request as ready for review March 9, 2021 01:47
@markmandel
Copy link
Member Author

🎉 THREE OUT OF THREE 🎉

@markmandel markmandel merged commit 88d423c into googleforgames:main Mar 9, 2021
@markmandel markmandel deleted the e2e/reduce-parrallel branch March 9, 2021 01:48
@markmandel markmandel added this to the 1.13.0 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/bug These are bugs. lgtm size/XS
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Flaky: e2e TestGameServerReadyAllocateReady
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey