camelCase playerID in log statements

[mthssdrbrg]

Noticed this while browsing the source, and to be consistent with other logs, as they seem to be using playerID instead of PlayerID.

What type of PR is this?

/kind cleanup

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[agones-bot]

Build Succeeded 👏

Build Id: c53fb50a-efed-4a3a-9b9e-1a726c1bd87d

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.14.0-6d848ca
• image: gcr.io/agones-images/agones-sdk:1.14.0-6d848ca
• image: gcr.io/agones-images/agones-ping:1.14.0-6d848ca
• Linux C++ SDK (build): agonessdk-1.14.0-6d848ca-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.14.0-6d848ca.zip

A preview of the website (the last 30 builds are retained):

• https://6d848ca-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2041/head:pr_2041 && git checkout pr_2041
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-6d848ca

[mthssdrbrg]

@googlebot I signed it!

[roberthbailey]

Which logs did you see that used playerID? The only other place where I see a log statement is

agones/pkg/sdkserver/localsdk.go

Line 404 in e048859

l.logger.WithField("playerID", id.PlayerID).Info("Player Connected")

.

[markmandel]

Which logs did you see that used playerID? The only other place where I see a log statement is

agones/pkg/sdkserver/localsdk.go

Line 404 in e048859

l.logger.WithField("playerID", id.PlayerID).Info("Player Connected")

.

Doing a quick search for .withField(...) - we do tend to standardise on starting with lowercase for key names. So seems like a reasonable cleanup?

[roberthbailey]

So seems like a reasonable cleanup?

SGTM.

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mthssdrbrg, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mthssdrbrg]

Just noticed that the logging in pkg/sdkserver/sdkserver.go uses playerId with a lowercase d whereas the logging in pkg/sdkserver/localsdk.go uses playerID 😅.

Suppose it would make sense to go with the Go way of capitalizing ID?

[roberthbailey]

Yes - it would be nice to match style.

[markmandel]

Just noticed that the logging in pkg/sdkserver/sdkserver.go uses playerId with a lowercase d whereas the logging in pkg/sdkserver/localsdk.go uses playerID .

Suppose it would make sense to go with the Go way of capitalizing ID?

+1 from me.

[google-oss-robot]

New changes are detected. LGTM label has been removed.

[mthssdrbrg]

Sweet, done, and rebased on latest main.

[agones-bot]

Build Failed 😱

Build Id: d353d817-fd6e-4888-a1ef-06e5d97e5c7e

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: a55c1d54-eff9-4b68-8e70-01a7bb79b5ca

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.14.0-0761b46
• image: gcr.io/agones-images/agones-ping:1.14.0-0761b46
• Linux C++ SDK (build): agonessdk-1.14.0-0761b46-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.14.0-0761b46.zip

A preview of the website (the last 30 builds are retained):

• https://0761b46-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2041/head:pr_2041 && git checkout pr_2041
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-0761b46