Feature gates for advanced Allocation filtering #2143
Conversation
|
Build Failed 😱 Build Id: 1c9e70bf-1d2a-4b92-a010-7faa4b7f58cb To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
When refactoring the allocator code for googleforgames#2143 I noticed that this function was never actually utilised for anything, so figured it made sense to remove it.
That's a new one! |
Adding the feature gates for the upcoming features. Specifically didn't add the gates to either the Makefile for the cloudbuild.yaml until the full feature has all it's functionality in place and it will pass tests. Work on googleforgames#1239
markmandel
force-pushed
the
feature/allocation-gates
branch
from
e7d5bb6
to
53563f0
Compare
|
Build Succeeded 👏 Build Id: 2e6c5725-a896-41fc-9a84-c9833aedaefc The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| FeatureSDKWatchSendOnExecute: true, | ||
| FeatureRollingUpdateOnReady: true, | ||
| NodeExternalDNS: false, | ||
| FeatureExample: true, |
There was a problem hiding this comment.
I wonder if we should keep these sorted somehow (alphabetical and/or based on true/false). Since they end up in a map the order they are inserted doesn't matter, but it may be useful to humans to have them in a logical ordering.
There was a problem hiding this comment.
🤔 they are currently in order of initial implementation (I think?).
I don't have strong opinions here tbh. Happy to take advice?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When refactoring the allocator code for #2143 I noticed that this function was never actually utilised for anything, so figured it made sense to remove it.
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 74b05da0-7822-462e-a370-d2c412eec188 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Adding the feature gates for the upcoming features.
Which issue(s) this PR fixes:
Work on #1239
Special notes for your reviewer:
Specifically didn't add the gates to either the Makefile for the cloudbuild.yaml until the full feature has all it's functionality in place and it will pass tests.