Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-init on gcloud-terraform-destroy-cluster #2161

Merged
merged 1 commit into from
Jun 25, 2021
Merged

terraform-init on gcloud-terraform-destroy-cluster #2161

merged 1 commit into from
Jun 25, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

On a clean machine, this target didn't work since I hadn't previously run make terraform-init on a different target.

This fixes that!

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

@markmandel
terraform-init on gcloud-terraform-destroy-cluster
9b4f387 
On a clean machine, this target didn't work since I hadn't previously
run `make terraform-init` on a different target.

This fixes that!
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Jun 25, 2021
@google-cla google-cla bot added the cla: yes label Jun 25, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 467a5df5-9c0c-4531-a0d6-b2ee156c2564

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2161/head:pr_2161 && git checkout pr_2161
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-9b4f387

aLekSer
aLekSer approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if tfstate file is needed for terraform destroy.
By the way Terraform just released 1.0 version.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 1ec6998 into googleforgames:main Jun 25, 2021
@markmandel markmandel deleted the cleanup/fix-clean branch June 25, 2021 21:28
@roberthbailey roberthbailey added this to the 1.16.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@aLekSer aLekSer

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markmandel @agones-bot @google-oss-robot @aLekSer @roberthbailey