-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rust Sample Docker image #2180
Fix Rust Sample Docker image #2180
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Looks like the Docker image and accompanying build scripts weren't updated with the move to Tonic, so it all went 💥. This fixes that, removing lots of dependencies we no long need (yay Tonic), upgrading the Rust version, and making sure all the relevant code (e.g. protos) are copies to the appropriate place when creating the Docker build image. Work on googleforgames#2179
13f99ba
to
0a1d3fc
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: ea45c860-4fd1-496b-989b-008f394cddf0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Looks like the Docker image and accompanying build scripts weren't updated with the move to Tonic, so it all went 💥.
This fixes that, removing lots of dependencies we no long need (yay Tonic), upgrading the Rust version, and making sure all the relevant code (e.g. protos) are copies to the appropriate place when creating the Docker build image.
Which issue(s) this PR fixes:
Work on #2179
Special notes for your reviewer: