Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation - add godot-sdk to third-party libraries-tools page #2182

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

AndreMicheletti
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / Why we need it:

Adds a new third-party sdk option for Godot Engine

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9bfd94eb-3c64-4ff8-aef5-0d74078c3a68

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

You can ignore this failure. (it's because of another build, don't worry). I'll kick it off again in a bit.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roberthbailey any concerns with merging this during feature freeze?

Also, I assume that this should close #2062 ?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 76b7a3cd-f8b5-4769-91af-07cdb9cb6624

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2182/head:pr_2182 && git checkout pr_2182
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-149ab20

@thisisnotapril
Copy link
Collaborator

@AndreMicheletti we'd love to have you talk about the SDK in a future project meeting!

@AndreMicheletti
Copy link
Contributor Author

@AndreMicheletti we'd love to have you talk about the SDK in a future project meeting!

Sure thing! Thank you for the invitation.

@roberthbailey
Copy link
Member

@roberthbailey any concerns with merging this during feature freeze?

Nope. This doesn't affect our release.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndreMicheletti, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 1db3ddf into googleforgames:main Jul 19, 2021
@roberthbailey roberthbailey added kind/documentation Documentation for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jul 19, 2021
@markmandel markmandel mentioned this pull request Jul 20, 2021
@roberthbailey roberthbailey added this to the 1.16.0 milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants