Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prost/prost-types #2190

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Conversation

Jake-Shadle
Copy link
Contributor

/kind hotfix

What this PR does / Why we need it:
There is a security vulnerability in prost-types which is an indirect dependency of prost/tonic, this just updates the packages to get the fix. The vulnerability probably doesn't matter for agones, but this just ensures that the agones dependencies are up to date as the rest of the ecosystem moves up.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f2adbbc4-8ee2-447d-9cfa-8b647c45996b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

Tests failed because I was resizing the e2e cluster and the control plane is currently unavailable. In cloud shell I'm currently seeing:

$ kubectl get pods                                                                                                                                                                  
The connection to the server 35.247.77.107 was refused - did you specify the right host or port?

I'll restart the tests once the control plane is accessible again.

@roberthbailey
Copy link
Member

This looks similar like it should make #2176 unnecessary.

@Jake-Shadle
Copy link
Contributor Author

Oh haha, awkward, that's my colleague and I was on vacation so didn't notice that PR. 😅

@roberthbailey
Copy link
Member

It would have merged already except for the missing CLA.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9341352a-2433-4135-9e81-58cb79699bf4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2190/head:pr_2190 && git checkout pr_2190
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-a818ccb

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can confirm that we can close #2176 in favour of this PR 👍🏻

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jake-Shadle, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Jul 22, 2021
@markmandel markmandel added this to the 1.17.0 milestone Jul 22, 2021
@markmandel markmandel merged commit 4e36de8 into googleforgames:main Jul 22, 2021
@Jake-Shadle Jake-Shadle deleted the update-prost branch April 2, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants