-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prost/prost-types #2190
Update prost/prost-types #2190
Conversation
Build Failed 😱 Build Id: f2adbbc4-8ee2-447d-9cfa-8b647c45996b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Tests failed because I was resizing the e2e cluster and the control plane is currently unavailable. In cloud shell I'm currently seeing:
I'll restart the tests once the control plane is accessible again. |
This looks similar like it should make #2176 unnecessary. |
Oh haha, awkward, that's my colleague and I was on vacation so didn't notice that PR. 😅 |
It would have merged already except for the missing CLA. |
Build Succeeded 👏 Build Id: 9341352a-2433-4135-9e81-58cb79699bf4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can confirm that we can close #2176 in favour of this PR 👍🏻
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jake-Shadle, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind hotfix
What this PR does / Why we need it:
There is a security vulnerability in
prost-types
which is an indirect dependency of prost/tonic, this just updates the packages to get the fix. The vulnerability probably doesn't matter for agones, but this just ensures that the agones dependencies are up to date as the rest of the ecosystem moves up.