Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Player Capacity Integration Pattern #2229

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Docs: Player Capacity Integration Pattern #2229

merged 2 commits into from
Aug 25, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Integration pattern documentation that outlines how to implement allocation based on player capacity with an accompanying sequence diagram.

Which issue(s) this PR fixes:

Work on #1239

Special notes for your reviewer:

To implement this, I also had to extend alpha.html shortcode such that it would be able to handle multiple feature gates.

@markmandel markmandel added kind/feature New features for Agones kind/documentation Documentation for Agones labels Aug 19, 2021
@google-cla google-cla bot added the cla: yes label Aug 19, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7b6c165f-cd0f-4596-96c9-d6b4944727f4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Flake:

time="2021-08-19 03:53:17.461" level=info msg="error waiting for fleet condition" error="timed out waiting for the condition" fleet=simple-fleet-2q86t
--- FAIL: TestAutoscalerBasicFunctions (331.87s)
    fleetautoscaler_test.go:81: error waiting for fleet condition on fleet simple-fleet-2q86t
FAIL
time="2021-08-19 03:53:17.712" level=info msg="Namespace 1629344724 is deleted"
FAIL	agones.dev/agones/test/e2e	473.213s
FAIL
Makefile:273: recipe for target 'test-e2e-integration' failed

Seems like this is a common flake 🤔 (anecdata)

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e98aeafc-3256-434d-a672-299de3a976a5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel force-pushed the docs/player-capacity-allocation branch from 2ae4f69 to 3344463 Compare August 19, 2021 20:21
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 18185f71-bb58-46e9-bfc1-a362e555cad1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel force-pushed the docs/player-capacity-allocation branch from 3344463 to da0b985 Compare August 19, 2021 21:01
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: aea67008-2db4-4ddf-a467-0c3f44c1c14e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2229/head:pr_2229 && git checkout pr_2229
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-da0b985

@markmandel markmandel force-pushed the docs/player-capacity-allocation branch from da0b985 to 7a92cf2 Compare August 19, 2021 21:54
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fc2030be-1e65-4bfd-901c-34ef7fd3954e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2229/head:pr_2229 && git checkout pr_2229
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-7a92cf2

roberthbailey
roberthbailey reviewed Aug 23, 2021
View reviewed changes
Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a manual rebase since the website.mk file was restructured a bit in your other PR.

site/layouts/shortcodes/alpha.html Show resolved Hide resolved
site/content/en/docs/Integration Patterns/player-capacity.md Outdated Show resolved Hide resolved
site/content/en/docs/Integration Patterns/player-capacity.md Outdated Show resolved Hide resolved
site/content/en/docs/Integration Patterns/player-capacity.md Outdated Show resolved Hide resolved
site/content/en/docs/Integration Patterns/player-capacity.md Outdated Show resolved Hide resolved
@markmandel
Docs: Player Capacity Integration Pattern
eeb7312 
Integration pattern documentation that outlines how to implement
allocation based on player capacity with an accompanying sequence
diagram.

To implement this, I also had to extend alpha.html shortcode such that
it would be able to handle multiple feature gates.

Work on googleforgames#1239
@markmandel
Review updates.
500567f
@markmandel markmandel force-pushed the docs/player-capacity-allocation branch from 7a92cf2 to 500567f Compare August 24, 2021 23:18
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9341dc7c-7bab-4667-90f7-829b3d1c56d8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2229/head:pr_2229 && git checkout pr_2229
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-500567f

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 0fca1fa into googleforgames:main Aug 25, 2021
@markmandel markmandel deleted the docs/player-capacity-allocation branch August 25, 2021 16:13
@markmandel markmandel added this to the 1.17.0 milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@roberthbailey roberthbailey

Labels
approved cla: yes kind/documentation Documentation for Agones kind/feature New features for Agones lgtm size/L
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey