Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev dependencies and audit fix security warning #2233

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

steven-supersolid
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Moderate level vulnerability. Only affects code coverage tool nyc

Moderate        Regular Expression Denial of Service in path-parse            

  Package         path-parse                                                    
  Dependency of   nyc [dev]                                                     

  Path            nyc > istanbul-lib-instrument > @babel/core > resolve >       
                  path-parse

Also taking this opportunity to update dev-dependencies but leaving dependencies as is due to closeness to RC.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added this to the 1.17.0 milestone Aug 24, 2021
@markmandel markmandel added the area/security Issues pertaining to security label Aug 24, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a933a819-8226-4813-a18f-0bade5a55865

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7d44252d-c213-4636-9a5c-9851b31c5b4e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2233/head:pr_2233 && git checkout pr_2233
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-dc5fd5d

@markmandel markmandel merged commit 15678b6 into googleforgames:main Aug 24, 2021
@steven-supersolid steven-supersolid deleted the update-node-deps branch December 12, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants