Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how namespaces work with allocations #2257

Merged
merged 4 commits into from
Sep 9, 2021

Conversation

eminguyen
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / Why we need it:

Adds a brief explanation on how namespaces work with allocations.

Which issue(s) this PR fixes:

Closes #2090

Special notes for your reviewer:

N/A

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0a497988-3274-4158-b440-0105a9238a85

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

Build failed due to infra issues. Running the e2e tests never finished as the cluster was unavailable:

Already have image: e2e-runner

Fetching cluster endpoint and auth data.
WARNING: cluster e2e-test-cluster is not RUNNING. The kubernetes API may or may not be available. Check the cluster status for more information.
kubeconfig entry generated for e2e-test-cluster.
Waiting consul port-forward to launch on 8500...

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 178fe3a2-2791-4aeb-a826-5c16113abdd7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d3c0919a-d450-4847-81b7-7cb336635ac5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: afbbf17e-9288-4e14-a5ad-9079f3e44871

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2257/head:pr_2257 && git checkout pr_2257
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-e0b87c2

Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added documentation, I've left a few comments to try and make it a bit more clear/precise.

site/content/en/docs/Reference/gameserverallocation.md Outdated Show resolved Hide resolved
site/content/en/docs/Reference/gameserverallocation.md Outdated Show resolved Hide resolved
site/content/en/docs/Reference/gameserverallocation.md Outdated Show resolved Hide resolved
site/content/en/docs/Reference/gameserverallocation.md Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7944ebd4-2e18-4f3a-bd53-5117c3f973b3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 031a11bd-424e-436e-9053-d85a3bb72165

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

--- FAIL: TestAutoscalerBasicFunctions (346.60s)
    fleetautoscaler_test.go:88: error waiting for fleet condition on fleet simple-fleet-m997v

@roberthbailey
Copy link
Member

I feel like we've been seeing more flaky tests recently....

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 29f9b0c6-ccf0-48f0-a101-45eedfea5bdf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2257/head:pr_2257 && git checkout pr_2257
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-2d610c4

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eminguyen, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 85a6917 into googleforgames:main Sep 9, 2021
@roberthbailey roberthbailey added this to the 1.18.0 milestone Sep 10, 2021
@roberthbailey roberthbailey added the kind/documentation Documentation for Agones label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain how namespace parameter works for allocations
4 participants