Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the node-forge dependency to address GHSA-5rrq-pxf6-6jx5 #2435

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

roberthbailey
Copy link
Member

See GHSA-5rrq-pxf6-6jx5

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: Fix a security vulnerability found by dependabot.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@roberthbailey roberthbailey added kind/cleanup Refactoring code, fixing up documentation, etc area/security Issues pertaining to security labels Jan 18, 2022
@roberthbailey
Copy link
Member Author

/assign @steven-supersolid

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1cda99f6-5777-4355-b24a-18beefe4b348

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2435/head:pr_2435 && git checkout pr_2435
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.20.0-c760f81

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3c0b81fe-ff7e-4616-81be-a0e0fda4acf0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8827a519-669e-4605-9336-75b424e6a2fb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 19, 2022
@roberthbailey
Copy link
Member Author

Failed in e2e-feature-gates:

--- FAIL: TestAutoscalerBasicFunctions (318.10s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:89
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestAutoscalerBasicFunctions
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-gpnms
FAIL

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ea2d88f7-ecd3-401e-83a2-66854da1de60

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

e2e-feature-gates:

--- FAIL: TestUpdateFleetReplicaAndSpec (87.60s)
    fleet_test.go:384: 
        	Error Trace:	fleet_test.go:384
        	Error:      	Condition never satisfied
        	Test:       	TestUpdateFleetReplicaAndSpec
        	Messages:   	Wrong number of GameServerSets

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: aa8fccc3-ece6-4fdc-b29a-e8a2c3d4b6f1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6ad7cea5-939e-422f-82e1-06fb08e10c54

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

This time sdk-conformance failed.

make[2]: *** [includes/sdk.mk:145: run-sdk-conformance-no-build] Error 1
make[1]: *** [includes/sdk.mk:153: run-sdk-conformance-test] Error 2
make: *** [includes/sdk.mk:163: run-sdk-conformance-test-go] Error 2
make: *** Waiting for unfinished jobs....

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d51c1bfb-5b9f-4a2b-9e34-d13eeac11dae

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2435/head:pr_2435 && git checkout pr_2435
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-1fca745

@roberthbailey roberthbailey merged commit e7cc7a7 into googleforgames:main Jan 19, 2022
@SaitejaTamma SaitejaTamma added this to the 1.21.0 milestone Feb 8, 2022
@roberthbailey roberthbailey deleted the node-forge branch March 28, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/security Issues pertaining to security kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants