Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate package-lock.json for the two node.js projects #2447

Merged

Conversation

steven-supersolid
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind cleanup

What this PR does / Why we need it:
Package versions in the sdk package-lock.json are not consistent and are causing problems with the same packages in the examples package-lock.json.
This PR removes both the previous lock files and regenerates so they should stay in sync

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:
We should also consider updating to Node.js 16 / npm 7 as this will simplify the contents of package-lock.json in examples to just reference the contents of the package-lock.json for the sdk instead of duplicating parts of it

@steven-supersolid
Copy link
Collaborator Author

/cc roberthbailey

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2566917b-cace-4f71-8bb5-74e269353a31

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2447/head:pr_2447 && git checkout pr_2447
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-d9c2097

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Member

@steven-supersolid - can you please rebase so that we can merge this?

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 24, 2022
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@steven-supersolid steven-supersolid changed the title Regenerate pacakge-lock.json for the two node.js projects Regenerate package-lock.json for the two node.js projects Jan 24, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8d209439-1e59-49da-8ba4-bbdb39b55da6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@steven-supersolid
Copy link
Collaborator Author

Unrelated test failing?

--- FAIL: TestFleetRecreateGameServers (0.00s)
    --- FAIL: TestFleetRecreateGameServers/gameserver_unhealthy (103.99s)
        fleet_test.go:1172: Could not message GameServer: timed out attempting to send UDP packet to address: timed out waiting for the condition

@roberthbailey
Copy link
Member

e2e-stable:

--- FAIL: TestFleetRecreateGameServers (0.00s)
    --- FAIL: TestFleetRecreateGameServers/gameserver_unhealthy (103.99s)
        fleet_test.go:1172: Could not message GameServer: timed out attempting to send UDP packet to address: timed out waiting for the condition
FAIL

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 92130c3c-b707-4b9c-8ef0-dd375b93e761

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2447/head:pr_2447 && git checkout pr_2447
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-ff483af

@roberthbailey roberthbailey merged commit b0f3b95 into googleforgames:main Jan 24, 2022
@SaitejaTamma SaitejaTamma added this to the 1.21.0 milestone Feb 8, 2022
@steven-supersolid steven-supersolid deleted the nodejs-sync-package-lock branch December 12, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants