-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate package-lock.json for the two node.js projects #2447
Regenerate package-lock.json for the two node.js projects #2447
Conversation
/cc roberthbailey |
Build Succeeded 👏 Build Id: 2566917b-cace-4f71-8bb5-74e269353a31 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roberthbailey, steven-supersolid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@steven-supersolid - can you please rebase so that we can merge this? |
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: 8d209439-1e59-49da-8ba4-bbdb39b55da6 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Unrelated test failing?
|
e2e-stable:
|
Build Succeeded 👏 Build Id: 92130c3c-b707-4b9c-8ef0-dd375b93e761 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Package versions in the sdk package-lock.json are not consistent and are causing problems with the same packages in the examples package-lock.json.
This PR removes both the previous lock files and regenerates so they should stay in sync
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer:
We should also consider updating to Node.js 16 / npm 7 as this will simplify the contents of package-lock.json in examples to just reference the contents of the package-lock.json for the sdk instead of duplicating parts of it