Hotfix: Ensure multiple Pods don't get created for a GameServer #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the cache is eventually consistent, there was a race condition in which a GameServer could create more than one Pod backing it, as the first one isn't found in the cache yet. This sync's the cache before checking this value, so the cache is up to date.
EricFortin
approved these changes
Aug 28, 2018
|
Build Succeeded 👏 Build Id: 6675350a-2900-482c-9b75-408970bd760e The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the cache is eventually consistent, there was a race condition in which a GameServer could create more than one Pod backing it, as the first one isn't found in the cache yet.
This sync's the cache before checking this value, so the cache is up to date.