Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change kubernetes API version to fix broken CI #3962

Merged
merged 1 commit into from
Aug 23, 2024
Merged

change kubernetes API version to fix broken CI #3962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions site/content/en/docs/Reference/gameserver.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ for `address`.)
The policy for `address` will work for many use-cases, but for some advanced cases, such as IPv6 enablement, you may need
to evaluate all `addresses` and pick the addresses that best suits your needs.

[addresses]: https://v1-26.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#nodeaddress-v1-core
[podIPs]: https://v1-26.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#podip-v1-core
[addresses]: https://v1-28.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#nodeaddress-v1-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[addresses]: https://v1-28.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#nodeaddress-v1-core
[addresses]: {{< k8s-api-version href="#nodeaddress-v1-core" >}}

Does this not work?

Copy link
Collaborator Author

@peterzhongyi peterzhongyi Aug 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this will fail: https://pantheon.corp.google.com/cloud-build/builds;region=global/49a4c639-318c-476a-8b60-6ff6811d35bd;step=19?e=13803378&mods=allow_workbench_image_override&project=agones-images

It's complaining something about some colon, but I can't make anything out of it

[podIPs]: https://v1-28.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#podip-v1-core
[addressFunc]: https://github.com/googleforgames/agones/blob/a59c5394c7f5bac66e530d21446302581c10c225/pkg/gameservers/gameservers.go#L37-L71
[gss]: {{% ref "/docs/Reference/agones_crd_api_reference.html#agones.dev/v1.GameServerStatus" %}}
2 changes: 1 addition & 1 deletion site/content/en/docs/Reference/gameserverallocation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ when using an API call. If not specified when using the command line, the [names

[gameserverselector]: {{% ref "/docs/Reference/agones_crd_api_reference.html#allocation.agones.dev/v1.GameServerSelector" %}}
[namespace]: https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces
[addresses]: https://v1-26.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#nodeaddress-v1-core
[addresses]: https://v1-28.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#nodeaddress-v1-core
[counterstatus]: {{% ref "/docs/Reference/agones_crd_api_reference.html#agones.dev/v1.CounterStatus" %}}
[liststatus]: {{% ref "/docs/Reference/agones_crd_api_reference.html#agones.dev/v1.ListStatus" %}}

Expand Down
Loading