Allowing list based fleet autoscaler to scale up from 0 replicas #4016

geopaulm · 2024-10-12T21:44:46Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
Updated the controller to initialize the list status map with empty AggregatedListStatus from fleet spec.
This allows scaling up if replicas is set to 0. Which is usually the case when deployed via Gitops systems ex. Flux.

Additionally updated the scaleUp function does limited scale to MinCapacity as well. Added this since I saw the desired capacity being set to Max first and then brought back to min! (This could be dangerous if the max is set to a high value)

I see that in most of the places we round up for calculating the number of replicas. This was missing for limited scaling using lists which is causing values to flap a bit for which I added a fix. Some of the tests were failing. Ex. to have a target max capacity of 45 with capacity of 10, the system was calculating 4 instead of 5. Let me know if that change is okay.

Which issue(s) this PR fixes:

Closes #3943

Special notes for your reviewer:

agones-bot · 2024-10-12T21:51:48Z

Build Failed 😭

Build Id: 25e4d80b-55cc-4532-8766-327c7aef4f6b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-10-12T22:08:37Z

Build Failed 😭

Build Id: 331c643b-c73d-4936-bb87-5c807f6ed5b9

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-10-13T00:17:33Z

Build Succeeded 🥳

Build Id: 3dace961-2d7e-4b5e-a39c-67940acfadb7

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-5b38729
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-5b38729
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-5b38729-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-5b38729
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-5b38729
Linux C++ SDK (build): agonessdk-1.45.0-dev-5b38729-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-5b38729.zip

A preview of the website (the last 30 builds are retained):

https://5b38729-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4016/head:pr_4016 && git checkout pr_4016
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-5b38729

igooch

Thanks for submitting the PR and tests!

pkg/fleets/controller.go

igooch · 2024-10-22T18:39:13Z

pkg/fleetautoscalers/fleetautoscalers.go

+		} else {
+			additionalReplicas = int32(math.Ceil((float64(minCapacity) - float64(aggCapacity)) / float64(capacity)))
+		}


I'm not sure we need this here? The case of scaling up to minCapacity should get caught here

agones/pkg/fleetautoscalers/fleetautoscalers.go

Line 319 in a27aeab

limited, scale := isLimited(aggCapacity, minCapacity, maxCapacity)

which eventually will call

agones/pkg/fleetautoscalers/fleetautoscalers.go

Line 510 in a27aeab

func scaleUpLimited(replicas int32, capacity, aggCapacity, minCapacity int64) (int32, bool, error) {

In this case limited = true, since aggCapacity = 0 is less than minCapacity.
Since the scaleup function only does a limit for MaxCapacity, the desired capacity is set to max value.
In the next run it will be set back to min value!. I saw this in the fleet autoscaler log. Isn't that dangerous?

I mean that the scaleUp function itself shouldn't be called when aggCapacity = 0. The function called when aggCapacity = 0 is scaleUpLimited.

pkg/fleetautoscalers/fleetautoscalers_test.go

…ontroller

agones-bot · 2024-10-23T21:48:34Z

Build Succeeded 🥳

Build Id: f259b1da-ce0c-4710-b641-d87f4cc659b4

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-72ae1c2
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-72ae1c2
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-72ae1c2-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-72ae1c2
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-72ae1c2
Linux C++ SDK (build): agonessdk-1.45.0-dev-72ae1c2-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-72ae1c2.zip

A preview of the website (the last 30 builds are retained):

https://72ae1c2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4016/head:pr_4016 && git checkout pr_4016
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-72ae1c2

agones-bot · 2024-10-31T17:21:51Z

Build Succeeded 🥳

Build Id: 0148e88a-48e7-42a2-929d-80dbe09607fe

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-67c11a0
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-67c11a0
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-67c11a0-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-67c11a0
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-67c11a0
Linux C++ SDK (build): agonessdk-1.45.0-dev-67c11a0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-67c11a0.zip

A preview of the website (the last 30 builds are retained):

https://67c11a0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4016/head:pr_4016 && git checkout pr_4016
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-67c11a0

igooch

LGTM, thanks for all your work on this!

pkg/fleetautoscalers/fleetautoscalers.go

agones-bot · 2024-10-31T23:19:08Z

Build Succeeded 🥳

Build Id: aaaab275-0af0-41e1-a3be-4b2d40010c48

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-87a7689
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-87a7689
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-87a7689-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-87a7689
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-87a7689
Linux C++ SDK (build): agonessdk-1.45.0-dev-87a7689-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-87a7689.zip

A preview of the website (the last 30 builds are retained):

https://87a7689-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4016/head:pr_4016 && git checkout pr_4016
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-87a7689

Allowing list based fleet autoscaler to scale up from 0 replicas

b4c7865

github-actions bot added kind/bug These are bugs. size/M labels Oct 12, 2024

Omiting discarded 2nd value from range

9fa76a4

Fixing unit tests

5b38729

geopaulm marked this pull request as draft October 12, 2024 23:03

geopaulm marked this pull request as ready for review October 13, 2024 18:06

markmandel requested a review from igooch October 15, 2024 01:01

igooch reviewed Oct 22, 2024

View reviewed changes

Moving the list initialization logic from fleet controller to gsset c…

72ae1c2

…ontroller

geopaulm requested a review from igooch October 24, 2024 21:14

Addressing PR comments

67c11a0

igooch approved these changes Oct 31, 2024

View reviewed changes

pkg/fleetautoscalers/fleetautoscalers.go Outdated Show resolved Hide resolved

Update pkg/fleetautoscalers/fleetautoscalers.go

87a7689

igooch enabled auto-merge (squash) October 31, 2024 22:12

igooch merged commit 0056256 into googleforgames:main Oct 31, 2024
4 checks passed

markmandel mentioned this pull request Nov 21, 2024

Fleet autoscaler with "Counter" policy throws an error if configured with a fleet with no replicas #4047

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allowing list based fleet autoscaler to scale up from 0 replicas #4016

Allowing list based fleet autoscaler to scale up from 0 replicas #4016

geopaulm commented Oct 12, 2024 •

edited

Loading

agones-bot commented Oct 12, 2024

agones-bot commented Oct 12, 2024

agones-bot commented Oct 13, 2024

igooch left a comment

igooch Oct 22, 2024

geopaulm Oct 24, 2024

igooch Oct 25, 2024

agones-bot commented Oct 23, 2024

agones-bot commented Oct 31, 2024

igooch left a comment

agones-bot commented Oct 31, 2024

Allowing list based fleet autoscaler to scale up from 0 replicas #4016

Allowing list based fleet autoscaler to scale up from 0 replicas #4016

Conversation

geopaulm commented Oct 12, 2024 • edited Loading

agones-bot commented Oct 12, 2024

agones-bot commented Oct 12, 2024

agones-bot commented Oct 13, 2024

igooch left a comment

Choose a reason for hiding this comment

igooch Oct 22, 2024

Choose a reason for hiding this comment

geopaulm Oct 24, 2024

Choose a reason for hiding this comment

igooch Oct 25, 2024

Choose a reason for hiding this comment

agones-bot commented Oct 23, 2024

agones-bot commented Oct 31, 2024

igooch left a comment

Choose a reason for hiding this comment

agones-bot commented Oct 31, 2024

geopaulm commented Oct 12, 2024 •

edited

Loading