Website for Agones #493
Merged
Website for Agones #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/feature
markmandel
force-pushed
the
feature/website
branch
from
b1732a5
to
be2ffc8
Compare
|
The site, as it would look for the current release: https://agones-mark.appspot.com/site/ |
markmandel
force-pushed
the
feature/website
branch
from
be2ffc8
to
b2de02f
Compare
|
Build Failed 😱 Build Id: d2b71daa-caba-4926-a959-8e73418f522d Build Logs |
markmandel
force-pushed
the
feature/website
branch
from
b2de02f
to
f3ebee6
Compare
|
Build Failed 😱 Build Id: 292da52e-6e15-4b1f-8f5b-10af405fb44c Build Logs |
|
Build Failed 😱 Build Id: 8167615f-d74f-40bb-8cb2-dec769d5e971 Build Logs |
|
Build Failed 😱 Build Id: 635e5125-be33-4b84-95f3-70f360a4bb76 Build Logs |
|
Build Failed 😱 Build Id: 435e7ed2-c6d1-4ae2-a854-f4cb3b2c065a Build Logs |
|
This was being flaky because of #494 - once that goes through, I'll run this test again. But the code can be reviewed, along with the website. |
|
Build Failed 😱 Build Id: b7ec6a6c-4908-4f98-be68-7ca337fa8050 Build Logs |
cyriltovena
suggested changes
Jan 22, 2019
There was a problem hiding this comment.
Overall it looks very good, I think we will need to work on the theme at some point as it looks not enough light and flat.(I'll give a go once it's merged)
It seems that all images are broken, see https://agones-mark.appspot.com/site/docs/reference/gameserver/ and https://agones-mark.appspot.com/site/docs/guides/metrics/.
The community section has a layout issue (not well centered) https://agones-mark.appspot.com/site/community/
cyriltovena
reviewed
Jan 22, 2019
cyriltovena
reviewed
Jan 22, 2019
|
Broken images should now be fixed. Working on making CloudBuild pass now. |
markmandel
force-pushed
the
feature/website
branch
from
710e6a2
to
110a51f
Compare
|
Build Failed 😱 Build Id: 7b02ddf1-176a-4ed5-961e-ece220e7b4c5 Build Logs |
markmandel
force-pushed
the
feature/website
branch
from
110a51f
to
c2e777a
Compare
|
Build Failed 😱 Build Id: a94928ea-120e-46fd-8bfd-6672c3b9a6ab Build Logs |
markmandel
force-pushed
the
feature/website
branch
from
c2e777a
to
d8bb7ea
Compare
|
Build Failed 😱 Build Id: 04d70899-3c17-4567-a213-f2b7b6b61bc9 Build Logs |
markmandel
force-pushed
the
feature/website
branch
2 times, most recently
from
f53d3ea
to
b918eef
Compare
|
Build Failed 😱 Build Id: f18d7cea-142a-4f19-bf00-20734dddf2cc Build Logs |
markmandel
force-pushed
the
feature/website
branch
from
b918eef
to
7198e65
Compare
|
Build Failed 😱 Build Id: fca32ec3-2d70-427e-817e-924145ace693 Build Logs |
markmandel
force-pushed
the
feature/website
branch
from
7198e65
to
76ba758
Compare
|
Build Failed 😱 Build Id: 9daa786a-b7fd-40a6-8cdf-d5aaa0772afe Build Logs |
|
Build Failed 😱 Build Id: 1d0b9540-07b5-4634-b314-fd4dedf4880e Build Logs |
markmandel
force-pushed
the
feature/website
branch
from
76ba758
to
c59626c
Compare
|
Build Failed 😱 Build Id: bec4e5dd-6299-48f6-a30b-d69fede68b81 Build Logs |
markmandel
force-pushed
the
feature/website
branch
from
c59626c
to
98fefd3
Compare
|
Build Succeeded 👏 Build Id: e6567ab9-21d0-4db1-9f90-ea84066f015e The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
|
Yay! it worked! https://98fefd3-dot-preview-dot-agones-images.appspot.com //cc @googlebot to unstick CLA. |
This is a new static site for Agones, as well as the tools to enable people to write documentation for new features, without it displaying until the feature is released. Integration with cloudbuild for previews is also build in (preview is the current documentation + all the documentation for the new features), as well as a link checker that runs as part of the test suite. This also brings into the codebase all the redirect code for go-get as well as the chart redirects as well. Closes googleforgames#410
markmandel
force-pushed
the
feature/website
branch
from
98fefd3
to
273f1f2
Compare
|
Build Failed 😱 Build Id: 8857fbee-42df-471b-b90a-8b15406422ac Build Logs |
|
Build Failed 😱 Build Id: fb2cb893-90db-42eb-bd82-ba693e278026 Build Logs |
|
Build Succeeded 👏 Build Id: ac623b32-394e-474b-845b-3f97a82e2dcf The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
cyriltovena
approved these changes
Jan 24, 2019
|
Build Succeeded 👏 Build Id: d545ef04-db31-4a6f-b0c3-043e31a4e4ba The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new static site for Agones, as well as the tools to enable people to
write documentation for new features, without it displaying until the feature
is released.
Integration with cloudbuild for previews is also build in (preview is the
current documentation + all the documentation for the new features), as well
as a link checker that runs as part of the test suite.
This also brings into the codebase all the redirect code for go-get as
well as the chart redirects as well.
Closes #410