Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrency bug in port allocator. #514

Merged
merged 1 commit into from
Jan 26, 2019
Merged

Fix concurrency bug in port allocator. #514

merged 1 commit into from
Jan 26, 2019

Conversation

markmandel
Copy link
Member

In some cases, not having this locked would cause a panic, which crashes the controller!

@markmandel
Fix concurrency bug in port allocator.
52c835e 
In some cases, not having this locked would
cause a panic, which crashes the controller!
@markmandel markmandel added the kind/bug These are bugs. label Jan 26, 2019
@markmandel markmandel added this to the 0.8.0 milestone Jan 26, 2019
cyriltovena
cyriltovena approved these changes Jan 26, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 78016f24-1c07-4394-8032-c33de59b4b29

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/514/head:pr_514 && git checkout pr_514
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-52c835e

@markmandel markmandel merged commit 78d4023 into googleforgames:master Jan 26, 2019
@markmandel markmandel deleted the bug/port-allocator branch January 26, 2019 01:24
@WontonSam WontonSam mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
kind/bug These are bugs.
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena