Fix for flaky TestSDKSetAnnotation #516
Conversation
markmandel
added
kind/cleanup
|
Build Succeeded 👏 Build Id: b0b151ed-eb8e-4aaa-8b2a-5233be24aec7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
| }) | ||
|
|
||
| assert.Nil(t, err) | ||
| assert.NotEmpty(t, gs.ObjectMeta.Annotations["stable.agones.dev/sdk-timestamp"]) | ||
|
|
||
| assert.NotEmpty(t, gs.ObjectMeta.Annotations[annotation]) |
There was a problem hiding this comment.
I distinctly remember seeing failures where "sdk-timestamp" was set but version was not.
There was a problem hiding this comment.
Can you try:
go test -count=100 -timeout 90s agones.dev/agones/test/e2e -run TestSDKSetAnnotation
There was a problem hiding this comment.
That would be strange, as the version annotation is set via a mutation webhook.
Ran this 50 times (in batches to fit under the timeout - also added a defer to delete the gameserver), no errors 🤷♂️
(Nice trick with -count=100 didn't know that one, will steal it 👍 )
markmandel
force-pushed
the
flaky/TestSDKSetAnnotation
branch
from
dad7c7d
to
9d2e284
Compare
Pretty sure the new version annotation on GameServers made this test flaky. This is a fix!
markmandel
force-pushed
the
flaky/TestSDKSetAnnotation
branch
from
9d2e284
to
d30d3b4
Compare
|
Build Succeeded 👏 Build Id: 5ae0ad36-29fc-408e-93dc-777031c42e13 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
Pretty sure the new version annotation on GameServers made this test flaky.
This is a fix!