Fixed gameserverset overshooting the number of GameServers #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during large turnups where some of the servers become unhealthy and get deleted. Now we treat Shutdown the same as deleted. Also fixed how we count # of servers in GSS to exclude Shutdown and deleted ones.
|
Build Succeeded 👏 Build Id: b45561c4-afff-4c97-85b7-a335d164797e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
reviewed
Feb 25, 2019
| @@ -321,6 +321,16 @@ func (gs *GameServer) GetDevAddress() (string, bool) { | |||
| return devAddress, hasDevAddress | |||
| } | |||
|
|
|||
| // IsAllocated returns true if the server is currently allocated. | |||
| func (gs *GameServer) IsAllocated() bool { | |||
There was a problem hiding this comment.
Thank you! I've been wanting to write this for weeks.
|
Build Succeeded 👏 Build Id: c8e29425-8941-4a14-a1ef-2ecb43feaa78 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens typically during large turnups where some of the servers become unhealthy and get deleted. Now we treat
Shutdownthe same as deleted.Also fixed how we count # of servers in GSS to exclude
Shutdownand deleted ones.Fixes #569