Refactor AllocationCounter to GameServerCounter #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 👏 Build Id: 72d09add-848a-421e-8bb5-103beabc7d07 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
aLekSer
reviewed
Mar 7, 2019
pkg/gameservers/gameservercounter.go
Outdated
| @@ -166,7 +169,7 @@ func (ac *AllocationCounter) Run(stop <-chan struct{}) error { | |||
| } | |||
|
|
|||
| // Counts returns the NodeCount map in a thread safe way | |||
| func (ac *AllocationCounter) Counts() map[string]NodeCount { | |||
| func (ac *GameServerCounter) Counts() map[string]NodeCount { | |||
There was a problem hiding this comment.
Nit: same as in the previous PR
Suggested change
| func (ac *GameServerCounter) Counts() map[string]NodeCount { | |
| func (gc *GameServerCounter) Counts() map[string]NodeCount { |
jkowalski
reviewed
Mar 7, 2019
pkg/gameservers/gameservercounter.go
Outdated
| @@ -29,11 +29,11 @@ import ( | |||
| "k8s.io/client-go/tools/cache" | |||
| ) | |||
|
|
|||
| // AllocationCounter counts how many Allocated and | |||
| // GameServerCounter counts how many Allocated and | |||
There was a problem hiding this comment.
nit: can we call it PerNodeCounter or something likethat? this is to avoid stuttering "gameservers.GameServerCounter", instead "gameservers.PerNodeCounter"
There was a problem hiding this comment.
I like it. That reads much better. Making this change!
markmandel
force-pushed
the
refactor/gameservercount
branch
from
21127c6
to
a5cd54d
Compare
|
Build Succeeded 👏 Build Id: 6b024e51-34ba-4421-a023-e37b67249d2d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
jkowalski
approved these changes
Mar 8, 2019
Precursor to googleforgames#638 - this moves the AllocationCounter code to a more central GameServerCounter (which I think is a better name) that tracks the number of Ready and Allocated GameServers that are available on each node. These details are useful for sorting for `Packed` scheduling strategies. Once this PR is completed, we can use this Count() values provided by this controller in the GameServerSet scale down logic, to ensure that GameServers on the least used nodes are removed first when using a Packed strategy.
markmandel
force-pushed
the
refactor/gameservercount
branch
from
a5cd54d
to
be0718d
Compare
|
Build Succeeded 👏 Build Id: 7c65795d-2107-4e45-bee5-3037a0e7e9d8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor to #638 - this moves the AllocationCounter code to a more central GameServerCounter (which I think is a better name) that tracks the number of Ready and Allocated GameServers that are
available on each node.
These details are useful for sorting for
Packedscheduling strategies.Once this PR is completed, we can use this Count() values provided by this controller in the GameServerSet scale down logic, to ensure that GameServers on the least used nodes are removed first when using a Packed strategy.