Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We no longer need gen-grpc-cpp.sh #710

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

markmandel
Copy link
Member

So deleting it!

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Apr 16, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 16, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0d014927-ef31-4b66-8811-5597fccbd0fa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/710/head:pr_710 && git checkout pr_710
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-3df4dea

@dsazonoff
Copy link
Contributor

@markmandel , we should keep this file until we will have custom gRPC version support in cmake (PR for that will be ready at 22-23 April).
Currently in case of updating gRPC version we need to regenerate and commit new files to repo. This file is not used in a build because it is not a part of a build. It's just a helper with necessary arguments for protobuf and with scripts to insert license text.

@markmandel
Copy link
Member Author

@dsazonoff
Copy link
Contributor

Sorry, it is. I'm wrong. I thought that this file was renamed to gen.sh by Cyril Tovena, when he moved out sdk build from main makefiles.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e6fc7e39-a0b2-4538-a556-c96994a951c6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/710/head:pr_710 && git checkout pr_710
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-ace481d

@markmandel markmandel merged commit 7e9e668 into googleforgames:master Apr 19, 2019
@markmandel markmandel deleted the cleanup/gen-grpc-cpp.sh branch April 19, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants