-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We no longer need gen-grpc-cpp.sh #710
We no longer need gen-grpc-cpp.sh #710
Conversation
So deleting it!
Build Succeeded 👏 Build Id: 0d014927-ef31-4b66-8811-5597fccbd0fa The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@markmandel , we should keep this file until we will have custom gRPC version support in cmake (PR for that will be ready at 22-23 April). |
But isn't this covered by this? https://github.com/GoogleCloudPlatform/agones/blob/master/build/build-sdk-images/cpp/gen.sh ? |
Sorry, it is. I'm wrong. I thought that this file was renamed to gen.sh by Cyril Tovena, when he moved out sdk build from main makefiles. |
Build Succeeded 👏 Build Id: e6fc7e39-a0b2-4538-a556-c96994a951c6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
So deleting it!