Add validation of the fleet underlying gameserver

[aLekSer]

Perform additional validation on a Fleet Gameserver specification .
For #765.

[agones-bot]

Build Succeeded 👏

Build Id: 7b783998-58f2-463f-8283-b37a62c2e3f9

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.10.0-3bd34f5
• image: gcr.io/agones-images/agones-sdk:0.10.0-3bd34f5
• image: gcr.io/agones-images/agones-ping:0.10.0-3bd34f5
• Linux C++ SDK (build): agonessdk-0.10.0-3bd34f5-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.10.0-3bd34f5.zip

A preview of the website (the last 30 builds are retained):

• https://3bd34f5-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/771/head:pr_771 && git checkout pr_771
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-3bd34f5

[markmandel]

So this is great for a quick and easy fix (which is nice 👍) - but makes me wonder if we should move some/all the validation functions down to the *Spec implementations - and then it would be far easier to pass this kind of things down?

Or maybe another way -

Add a Validate() to GameServerTemplate that calls a GameServerSpec.Validate(), which is also called by GameServer.Validate()

WDYT? Would that be cleaner / easier to maintain?

[aLekSer]

Agree with you, need to update this PR.

[agones-bot]

Build Succeeded 👏

Build Id: 0054c115-9520-4911-b34c-6abb5211b7d0

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.10.0-c2a3f8f
• image: gcr.io/agones-images/agones-sdk:0.10.0-c2a3f8f
• image: gcr.io/agones-images/agones-ping:0.10.0-c2a3f8f
• Linux C++ SDK (build): agonessdk-0.10.0-c2a3f8f-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.10.0-c2a3f8f.zip

A preview of the website (the last 30 builds are retained):

• https://c2a3f8f-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/771/head:pr_771 && git checkout pr_771
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-c2a3f8f

[markmandel]

Should we write a e2e test for this? WDYT?

[aLekSer]

Yes, I will prepare E2E test for this change

[agones-bot]

Build Succeeded 👏

Build Id: fdc50694-e2b8-4dfe-b8ca-fea412f5e2b9

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.10.0-ed4a972
• image: gcr.io/agones-images/agones-sdk:0.10.0-ed4a972
• image: gcr.io/agones-images/agones-ping:0.10.0-ed4a972
• Linux C++ SDK (build): agonessdk-0.10.0-ed4a972-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.10.0-ed4a972.zip

A preview of the website (the last 30 builds are retained):

• https://ed4a972-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/771/head:pr_771 && git checkout pr_771
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-ed4a972

[agones-bot]

Build Succeeded 👏

Build Id: 7b807612-3c2c-4a21-86f0-0591b3405fe6

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.10.0-6f3c727
• image: gcr.io/agones-images/agones-sdk:0.10.0-6f3c727
• image: gcr.io/agones-images/agones-ping:0.10.0-6f3c727
• Linux C++ SDK (build): agonessdk-0.10.0-6f3c727-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.10.0-6f3c727.zip

A preview of the website (the last 30 builds are retained):

• https://6f3c727-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/771/head:pr_771 && git checkout pr_771
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-6f3c727

[agones-bot]

Build Succeeded 👏

Build Id: f6b67079-00e6-4e32-8a5e-4b5796115e2c

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.10.0-0b21047
• image: gcr.io/agones-images/agones-sdk:0.10.0-0b21047
• image: gcr.io/agones-images/agones-ping:0.10.0-0b21047
• Linux C++ SDK (build): agonessdk-0.10.0-0b21047-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.10.0-0b21047.zip

A preview of the website (the last 30 builds are retained):

• https://0b21047-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/771/head:pr_771 && git checkout pr_771
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-0b21047

[agones-bot]

Build Succeeded 👏

Build Id: c34f17b5-95af-4fe5-8034-27260b02af95

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.11.0-823d94b
• image: gcr.io/agones-images/agones-sdk:0.11.0-823d94b
• image: gcr.io/agones-images/agones-ping:0.11.0-823d94b
• Linux C++ SDK (build): agonessdk-0.11.0-823d94b-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.11.0-823d94b.zip

A preview of the website (the last 30 builds are retained):

• https://823d94b-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/771/head:pr_771 && git checkout pr_771
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-823d94b

[markmandel]

Nice! 🍹