Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK page with full list of current SDKs. #778

Merged
merged 1 commit into from
May 23, 2019
Merged

Update SDK page with full list of current SDKs. #778

merged 1 commit into from
May 23, 2019

Conversation

markmandel
Copy link
Member

Also made a better landing page for the Go SDK

@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels May 17, 2019
@markmandel markmandel added this to the 0.11.0 milestone May 17, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 15a4f23c-3b27-46fc-94ce-8d373b8319f1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/778/head:pr_778 && git checkout pr_778
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-7070005

@roberthbailey
Copy link
Member

lgtm

pooneh-m
pooneh-m reviewed May 22, 2019
View reviewed changes
site/content/en/docs/Guides/Client SDKs/_index.md
- [Go](https://godoc.org/agones.dev/agones/sdks/go)
- [Node.js]({{< relref "nodejs.md" >}})
- [Go]({{< relref "go.md" >}})
- [Rust]({{< relref "rust.md" >}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the local.md?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a section below this:

There is also local development tooling for working against the SDK locally, without having to spin up an entire Kubernetes infrastructure.

That work?

site/content/en/docs/Guides/Client SDKs/go.md
---
title: "Go Game Server Client SDK"
linkTitle: "Go"
date: 2019-05-17T10:17:50Z
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this date referring to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date the page got created, that's it.
https://gohugo.io/content-management/front-matter/

In this case, it's not particularly relevant.

@markmandel
Update SDK page with full list of current SDKs.
8845377 
Also made a better landing page for the Go SDK
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 988b129a-c635-4935-8250-6c037f3a6023

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/778/head:pr_778 && git checkout pr_778
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-8845377

@pooneh-m pooneh-m merged commit 843aee0 into googleforgames:master May 23, 2019
@markmandel markmandel deleted the cleanup/sdk-pages branch May 23, 2019 19:30
@roberthbailey roberthbailey mentioned this pull request Jul 16, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @roberthbailey @pooneh-m