Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HandleError input parameter check #798

Merged
merged 1 commit into from
May 30, 2019
Merged

Add HandleError input parameter check #798

merged 1 commit into from
May 30, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented May 29, 2019

There could be a panic on HandleError logging functionality.
Add test coverage for that particular case.

@aLekSer
Add HandleError input parameter check
7b8b752 
There could be a panic on HandleError logging functionality. Add test
coverage for that.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5ad16648-7e8a-40c7-8fb4-6575e8d6e022

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/798/head:pr_798 && git checkout pr_798
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-7b8b752

ilkercelikyilmaz
ilkercelikyilmaz approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@ilkercelikyilmaz ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel merged commit 2f0e42d into googleforgames:master May 30, 2019
@aLekSer aLekSer deleted the handle-error-check branch May 31, 2019 07:20
@markmandel markmandel added this to the 0.11.0 milestone Jun 12, 2019
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkercelikyilmaz ilkercelikyilmaz ilkercelikyilmaz approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aLekSer @agones-bot @ilkercelikyilmaz @markmandel