Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FleetAutoscaling to autoscaling.agones.dev group #829

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Move FleetAutoscaling to autoscaling.agones.dev group #829

merged 2 commits into from
Jun 17, 2019

Conversation

markmandel
Copy link
Member

This is a pure refactor, to move FleetAutoscaling to the group outlined in #703, where it will stay.

Did this one first, since it seemed like the easiest one to tackle.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/breaking Breaking change labels Jun 13, 2019
aLekSer
aLekSer reviewed Jun 13, 2019
View reviewed changes
pkg/apis/autoscaling/register.go Outdated
@@ -0,0 +1,20 @@
// Copyright 2019 Google Inc. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit as per #699 pull request and in other files.

Suggested change
// Copyright 2019 Google Inc. All Rights Reserved.
// Copyright 2019 Google LLC All Rights Reserved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - excellent catch. Will fix!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

aLekSer
aLekSer reviewed Jun 13, 2019
View reviewed changes
pkg/apis/autoscaling/v1alpha1/register.go Outdated
@@ -0,0 +1,59 @@
// Copyright 2019 Google Inc. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2019 Google Inc. All Rights Reserved.
// Copyright 2019 Google LLC All Rights Reserved.

aLekSer
aLekSer reviewed Jun 13, 2019
View reviewed changes
pkg/apis/autoscaling/v1alpha1/doc.go Outdated
@@ -0,0 +1,19 @@
// Copyright 2019 Google Inc. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2019 Google Inc. All Rights Reserved.
// Copyright 2019 Google LLC All Rights Reserved.

aLekSer
aLekSer reviewed Jun 13, 2019
View reviewed changes
pkg/apis/autoscaling/v1alpha1/fleetautoscaler.go Outdated
@@ -1,4 +1,4 @@
// Copyright 2018 Google LLC All Rights Reserved.
// Copyright 2019 Google Inc. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2019 Google Inc. All Rights Reserved.
// Copyright 2019 Google LLC All Rights Reserved.

aLekSer
aLekSer reviewed Jun 13, 2019
View reviewed changes
site/content/en/docs/Getting Started/create-fleetautoscaler.md Outdated
@@ -30,9 +30,17 @@ kubectl apply -f https://raw.githubusercontent.com/GoogleCloudPlatform/agones/{{

You should see a successful output similar to this :

{{% feature expiryVersion="0.10.0" %}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should expiry at the same moment as new one published

Suggested change
{{% feature expiryVersion="0.10.0" %}}
{{% feature expiryVersion="0.11.0" %}}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeees. Good point.

aLekSer
aLekSer reviewed Jun 13, 2019
View reviewed changes
site/content/en/docs/Getting Started/create-fleetautoscaler.md Outdated
@@ -44,6 +52,7 @@ kubectl describe fleetautoscaler simple-udp-autoscaler

It should look something like this:

{{% feature expiryVersion="0.10.0" %}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% feature expiryVersion="0.10.0" %}}
{{% feature expiryVersion="0.11.0" %}}

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a045e9b5-829f-4fa5-845a-dfd6d0187a98

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9d538c24-abfe-4da9-8a5b-e40faaed1830

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: af168818-8d3d-48c5-9fc6-0237bc8d089f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Kubernetes is being super, super weird - looks like it caching the discovery path for the fleetautoscaler to the old group. Doing a full helm delete agones -purge to see if it solves the issue.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: dccb4c73-339f-4951-9143-82c81c93b152

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Next attempt - upgrade to 1.11.10, and update the nodes too.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 227d41b6-8547-4d62-985f-e5d89ede5360

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

it was not k8s, it was a small thing in my code. Worked it out, will published again when this is ready for review (it's not right now).

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: eb8dda6c-e29c-4cc2-a653-2a040da18e08

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Move FleetAutoscaling to autoscaling.agones.dev group
937217b 
This is a pure refactor, to move FleetAutoscaling to the group outlined
in googleforgames#703, where it will stay.

Did this one first, since it seemed like the easiest one to tackle.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f490e659-5263-4a78-a7eb-fef0e3edfef5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/829/head:pr_829 && git checkout pr_829
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-937217b

@markmandel
Copy link
Member Author

This is now ready for review 👍

(That was fun!)

pooneh-m
pooneh-m reviewed Jun 17, 2019
View reviewed changes
Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring!

test/e2e/fleetautoscaler_test.go
@@ -20,7 +20,8 @@ import (
"testing"
"time"

"agones.dev/agones/pkg/apis/stable/v1alpha1"
"agones.dev/agones/pkg/apis/autoscaling/v1alpha1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep this consistent throughout the tests? Like stablev1alpha1 and autoscalingv1alpha1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's a fair point 👍 I'll jump on it.

Right now it's a bit "v1alpha1" is the import if that's the most specific thing you are working on (for better or worse), and I think it's mostly like that in a lot of the codebase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this change to make sure this gets in for v0.11 release. We can fix this in future PRs.

test/e2e/fleetautoscaler_test.go
@@ -43,16 +44,16 @@ var waitForDeletion = &metav1.DeleteOptions{
func TestAutoscalerBasicFunctions(t *testing.T) {
t.Parallel()

alpha1 := framework.AgonesClient.StableV1alpha1()
fleets := alpha1.Fleets(defaultNs)
stable := framework.AgonesClient.StableV1alpha1()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoscaling := framework.AgonesClient.AutoscalingV1alpha1()

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2ddfa162-4dbb-473b-9e8c-5db28da78962

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/829/head:pr_829 && git checkout pr_829
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-3f41010

@pooneh-m pooneh-m merged commit 31c212f into googleforgames:master Jun 17, 2019
@markmandel markmandel deleted the refactor/group-allocation branch June 17, 2019 23:40
@markmandel markmandel added this to the 0.11.0 milestone Jun 18, 2019
@roberthbailey roberthbailey mentioned this pull request Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@aLekSer aLekSer aLekSer left review comments

Assignees
No one assigned
Labels
kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @aLekSer @pooneh-m