Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minikube developer experience #898

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Fix minikube developer experience #898

merged 3 commits into from
Jul 15, 2019

Conversation

markmandel
Copy link
Member

There were some missing attributes and images from the minikube
targets so allocator was not starting up.

This puts them in, and now everything works again!

@markmandel
Fix minikube developer experience
404c5e9 
There were some missing attributes and images from the minikube
targets so allocator was not starting up.

This puts them in, and now everything works again!
@markmandel markmandel added kind/bug These are bugs. area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Jul 11, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a91e38e0-d621-46db-a29c-ea6795ec8445

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

lgtm

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 190ff196-3254-4998-a331-aebade601b19

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e5564073-fac0-43b7-b838-cad71a78cec3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/898/head:pr_898 && git checkout pr_898
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-5fb868d

cyriltovena
cyriltovena approved these changes Jul 15, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have the same in my branch for kind, if anyone needs it also.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 15d4cebe-bea4-4c9e-9f68-30bdf299f71a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/898/head:pr_898 && git checkout pr_898
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-a3e9924

@markmandel markmandel merged commit 77e5511 into googleforgames:master Jul 15, 2019
@markmandel markmandel deleted the bug/dev-minikube branch July 15, 2019 16:24
@roberthbailey roberthbailey mentioned this pull request Jul 16, 2019
Closed
5 tasks
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/bug These are bugs.
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @roberthbailey @cyriltovena