Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the command to teardown the test cluster in the GKE developer instructions. #916

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Fix the command to teardown the test cluster in the GKE developer instructions. #916

merged 2 commits into from
Jul 18, 2019

Conversation

roberthbailey
Copy link
Member

The cluster to run e2e tests is created with make gcloud-test-cluster which makes a cluster named test-cluster. The current instructions to tear down the cluster try to delete a cluster named e2e-test-cluster instead.

@roberthbailey roberthbailey added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Jul 17, 2019
markmandel
markmandel approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jul 17, 2019
@markmandel markmandel added this to the 0.12.0 milestone Jul 17, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c905eee9-214b-4a33-8e1a-ed18bfb7e29a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c33c7ee0-a538-4a6a-9405-ac4f08715fea

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/916/head:pr_916 && git checkout pr_916
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-0c972f9

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c6c526f7-3290-4d34-950e-dd8603c6d729

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/916/head:pr_916 && git checkout pr_916
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-f22f2ab

@markmandel markmandel merged commit c83d80c into googleforgames:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@roberthbailey @agones-bot @markmandel