Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.js coverage, dependencies and potential issue #954

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

steven-supersolid
Copy link
Collaborator

Restore test coverage - this had dropped a little with previous changes

Fix potential issue - Adding tests showed that all error messages were being captured in watchGameServer. I don't believe this was the original intention of the previous change but if it was then we can now modify the test and code accordingly

Update dependencies - the two dependencies have updates which fix security warnings and this removes the need for including the sub-dependency

Apply consistent style - I was trying to avoid style rules but the original code was written with some rules in mind that aren't covered by eslint:recommended

Ensure the example exits when an error is thrown

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3c5dddcc-0da9-4e43-9cfa-2c24cfb5c3c8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/954/head:pr_954 && git checkout pr_954
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-b836268

@markmandel markmandel added area/security Issues pertaining to security area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jul 29, 2019
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me - but I'm no judge of node. Going to push it through so we can get the security fix in place.

Looks like mostly syntactic, formatting and test changes. 👍

@markmandel markmandel merged commit 2df57d7 into googleforgames:master Jul 29, 2019
@markmandel markmandel added this to the 0.12.0 milestone Jul 29, 2019
@steven-supersolid steven-supersolid deleted the nodejs.coverage branch March 14, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Issues pertaining to security area/tests Unit tests, e2e tests, anything to make sure things don't break area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants