-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of EKS terraform config #986
Conversation
Build Succeeded 👏 Build Id: 17d861c1-c44a-4323-bf1f-8f1070a78c8f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Today I spend some hours trying to get the config similar to the one created using |
Build Failed 😱 Build Id: 4ae5f801-15b8-4e63-98eb-6fdc06d59471 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Fail in E2E test:
|
Build Failed 😱 Build Id: d4fd5a25-e4b1-41ff-8ecb-9faeaf23ac51 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 680715f7-60e8-49a4-9fce-30d26816ef87 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Experienced an issue with |
7821692
to
635bce0
Compare
Build Succeeded 👏 Build Id: 3433e739-415d-4158-900f-9e5c4458c0ae The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
I have tested switching from |
e1f6146
to
baa5f76
Compare
Build Failed 😱 Build Id: 72e06b41-8b0c-4ab1-aab1-90d08fcbc75a To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
It seems to be that we met this issue: |
Build Succeeded 👏 Build Id: ad767902-80bf-46a0-88b0-07d9ba820914 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
baa5f76
to
e9dc07b
Compare
There is still a problem with
I have added a workaround for this issue (in the documents also):
I think we should wait for a fix in original Terraform provider repo or propose some way to
|
By the way I have verified AWS Security Group for UDP traffic and it works as expected with |
Build Succeeded 👏 Build Id: 0807e4dd-5022-4b6d-89c5-73f9a1405bb9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
e9dc07b
to
0d9cbbe
Compare
Build Succeeded 👏 Build Id: 8d559665-b7a1-41b8-b93d-1a2de03cafd0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: e12af785-75e5-44c7-b3a5-4b4408df0b22 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 4bc8220e-4858-4c8d-a011-38f9a19ee830 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 151d9abe-eeaa-458b-b3c5-3e2e72ac4b68 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
||
|
||
{{< alert title="Note" color="info" >}} | ||
Current EKS config does not contain Helm Terraform configuration as for other Cloud Providers. That's because of a known issue with AWS Terraform provider: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current EKS config does not contain Helm Terraform configuration as for other Cloud Providers. That's because of a known issue with AWS Terraform provider: | |
Current EKS config does not contain Helm Terraform configuration as for other Cloud Providers. That's because of a known issue with the AWS Terraform provider: |
{{< alert title="Note" color="info" >}} | ||
There is an issue with terraform AWS provider: | ||
https://github.com/terraform-providers/terraform-provider-aws/issues/9101 | ||
Due to the issue you should remove helm release first, otherwise `terraform destroy` will timeout and never succeed. Remove all created resources manually in that case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe silly question:
If we're directing people to potentially manually install Agones via Helm - but they will still run into the same issue - why don't we direct people to this workaround and install Agones via Helm for this via the Terraform provider, since they will likely have to do the workaround anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, I was not thinking this way, will check this today. helm delete
before terraform destroy
already in the docs so.
Build Succeeded 👏 Build Id: c34bf1f6-fa68-4eaf-9986-e9b1cba2ad36 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Tested that :
is working, while:
Leads to timeout:
|
Now more variables are supported and documented:
|
Build Failed 😱 Build Id: 32a56923-8e39-4f79-9579-5c42c68f19f1 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
New E2E test fail:
|
Build Succeeded 👏 Build Id: c2a6b93c-eac7-40cd-9eec-b0ba25cee3ad The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
name = "${var.cluster_name}" | ||
} | ||
|
||
// TODO(alekser): Fix next Helm submodule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest changes, is this TODO still relevant?
Otherwise, this looks G2G.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will get rid of this TODO, the issue is referenced in the docs.
It provisions all necessary resouces and firewall rules. Helm provider left in TODO, because adding it makes "terraform destroy" fail.
4e46f22
to
dc95769
Compare
Build Succeeded 👏 Build Id: e47266fc-f83d-46fa-b7ae-68722d8b8c08 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 936847c7-ea31-429e-9b67-a334350cecff The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It provisions all necessary resouces and firewall rules. Helm provider left in TODO, because adding it makes "terraform destroy" fail.
Add module for EKS cluster. Add documentation and example which uses submodules.
Disabled
agones-system/agones-ping-udp-service
for now as it breaks thehelm_agones
deployment.There is a need to add two more Node Pools ( Worker Groups) for metrics and system with taints.
Closes #966 .