Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update targetSdk = compileSdk = 34 for Maps and Places #1427

Closed
sgilsonapigee opened this issue Dec 5, 2023 · 1 comment · Fixed by #1428
Closed

Update targetSdk = compileSdk = 34 for Maps and Places #1427

sgilsonapigee opened this issue Dec 5, 2023 · 1 comment · Fixed by #1428
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@sgilsonapigee
Copy link

Please be sure to include as much information as possible:

Environment details

For Mapls and Places, for both Kotlin and Java samples, we need to update the target and min SDKs to 34:

targetSdk = compileSdk = 34
@sgilsonapigee sgilsonapigee added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. labels Dec 5, 2023
@kikoso kikoso added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Dec 5, 2023
@kikoso kikoso mentioned this issue Dec 6, 2023
Merged
4 tasks
@kikoso
Copy link
Collaborator

kikoso commented Dec 6, 2023

Hi @sgilsonapigee,

The following PR will fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: updated targetSdk and compileSdk googlemaps-samples/android-samples
2 participants
@kikoso @sgilsonapigee