test: fix places/photo test #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlemaps-bot
added a commit
that referenced
this pull request
Dec 12, 2023
### [3.3.42](v3.3.41...v3.3.42) (2023-12-12) ### Build System * **deps-dev:** bump @babel/traverse from 7.23.0 to 7.23.2 ([#1058](#1058)) ([820544c](820544c)) * **deps-dev:** bump @types/jest from 29.5.5 to 29.5.7 ([#1070](#1070)) ([8a4ec75](8a4ec75)) * **deps-dev:** bump @types/jest from 29.5.7 to 29.5.10 ([#1092](#1092)) ([d2b74f1](d2b74f1)) * **deps-dev:** bump @types/node from 20.10.0 to 20.10.3 ([#1102](#1102)) ([e6cd0e7](e6cd0e7)) * **deps-dev:** bump @types/node from 20.10.3 to 20.10.4 ([#1111](#1111)) ([374b7b6](374b7b6)) * **deps-dev:** bump @types/node from 20.8.4 to 20.8.6 ([#1056](#1056)) ([917c616](917c616)) * **deps-dev:** bump @types/node from 20.8.6 to 20.8.7 ([#1059](#1059)) ([d2ed837](d2ed837)) * **deps-dev:** bump @types/node from 20.8.7 to 20.9.0 ([#1080](#1080)) ([3c7cfda](3c7cfda)) * **deps-dev:** bump @types/node from 20.9.0 to 20.9.2 ([#1087](#1087)) ([d5d5521](d5d5521)) * **deps-dev:** bump @types/node from 20.9.2 to 20.10.0 ([#1096](#1096)) ([40030b0](40030b0)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#1055](#1055)) ([f1674df](f1674df)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#1062](#1062)) ([dbf243b](dbf243b)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#1071](#1071)) ([b36384e](b36384e)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#1073](#1073)) ([4e7ac73](4e7ac73)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#1085](#1085)) ([80697e6](80697e6)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#1088](#1088)) ([de1a052](de1a052)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#1108](#1108)) ([3701d7e](3701d7e)) * **deps-dev:** bump @typescript-eslint/parser from 6.10.0 to 6.11.0 ([#1084](#1084)) ([3e8bcdd](3e8bcdd)) * **deps-dev:** bump @typescript-eslint/parser from 6.11.0 to 6.12.0 ([#1089](#1089)) ([895dbd3](895dbd3)) * **deps-dev:** bump @typescript-eslint/parser from 6.12.0 to 6.13.0 ([#1095](#1095)) ([1c42682](1c42682)) * **deps-dev:** bump @typescript-eslint/parser from 6.13.0 to 6.13.2 ([#1103](#1103)) ([b8f1741](b8f1741)) * **deps-dev:** bump @typescript-eslint/parser from 6.7.5 to 6.8.0 ([#1057](#1057)) ([1aa5649](1aa5649)) * **deps-dev:** bump @typescript-eslint/parser from 6.8.0 to 6.9.0 ([#1063](#1063)) ([4dee296](4dee296)) * **deps-dev:** bump @typescript-eslint/parser from 6.9.0 to 6.9.1 ([#1069](#1069)) ([bd98de5](bd98de5)) * **deps-dev:** bump @typescript-eslint/parser from 6.9.1 to 6.10.0 ([#1075](#1075)) ([781ce3e](781ce3e)) * **deps-dev:** bump eslint from 8.51.0 to 8.52.0 ([#1060](#1060)) ([8f7eb83](8f7eb83)) * **deps-dev:** bump eslint from 8.52.0 to 8.53.0 ([#1077](#1077)) ([36e67f0](36e67f0)) * **deps-dev:** bump eslint from 8.53.0 to 8.54.0 ([#1090](#1090)) ([67c0e48](67c0e48)) * **deps-dev:** bump eslint from 8.54.0 to 8.55.0 ([#1101](#1101)) ([56f5d88](56f5d88)) * **deps-dev:** bump eslint-config-prettier from 9.0.0 to 9.1.0 ([#1099](#1099)) ([4b6f1ae](4b6f1ae)) * **deps-dev:** bump eslint-plugin-jest from 27.4.2 to 27.4.3 ([#1061](#1061)) ([e5c37be](e5c37be)) * **deps-dev:** bump eslint-plugin-jest from 27.4.3 to 27.6.0 ([#1076](#1076)) ([28624ad](28624ad)) * **deps-dev:** bump nock from 13.3.4 to 13.3.7 ([#1068](#1068)) ([1a780bc](1a780bc)) * **deps-dev:** bump nock from 13.3.7 to 13.3.8 ([#1074](#1074)) ([f1bee09](f1bee09)) * **deps-dev:** bump nock from 13.3.8 to 13.4.0 ([#1094](#1094)) ([04ce099](04ce099)) * **deps-dev:** bump prettier from 3.0.3 to 3.1.0 ([#1082](#1082)) ([3c472fd](3c472fd)) * **deps-dev:** bump prettier from 3.1.0 to 3.1.1 ([#1109](#1109)) ([785ff4a](785ff4a)) * **deps-dev:** bump typedoc from 0.25.2 to 0.25.3 ([#1067](#1067)) ([eecbe98](eecbe98)) * **deps-dev:** bump typedoc from 0.25.3 to 0.25.4 ([#1093](#1093)) ([cf24d22](cf24d22)) * **deps-dev:** bump typescript from 5.2.2 to 5.3.2 ([#1097](#1097)) ([9212502](9212502)) * **deps-dev:** bump typescript from 5.3.2 to 5.3.3 ([#1112](#1112)) ([eedf7b0](eedf7b0)) * **deps:** bump @googlemaps/url-signature from 1.0.29 to 1.0.30 ([#1110](#1110)) ([4400a37](4400a37)) * **deps:** bump axios from 1.5.1 to 1.6.0 ([#1079](#1079)) ([c5e3c9a](c5e3c9a)) * **deps:** bump axios from 1.6.0 to 1.6.1 ([#1081](#1081)) ([392a38b](392a38b)) * **deps:** bump axios from 1.6.1 to 1.6.2 ([#1091](#1091)) ([031213f](031213f)) * **deps:** bump crypto-js from 4.1.1 to 4.2.0 ([#1066](#1066)) ([51383bf](51383bf)) ### Miscellaneous Chores * add eslint and fix problems ([#1045](#1045)) ([67e5de8](67e5de8)) * update workflows to use newer versions ([#1046](#1046)) ([52b256f](52b256f)) ### Tests * fix places/photo test ([#1113](#1113)) ([1be71ac](1be71ac))
|
🎉 This PR is included in version 3.3.42 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Sep 20, 2024
This was referenced Sep 21, 2024
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the failing tests observed in recent workflow-runs.
The test for the Place Photos API was using a hardcoded
photoreferencewhich apparently is no longer valid.The updated test retrieves a photo reference via place details request, which should always produce valid results.
Also changed the way the tests are run. This includes specifying
--runInBandvia command line (avoid problems with serializing error-objects with cyclic structure) and only using--collectCoveragewhen running tests via npm when it's actually required.