Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add Util.getQuaternionAngle to fix debug mode #296

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

MattiasBuelens
Copy link
Contributor

When debug mode is activated on mobile devices, the polyfill throws a lot of errors:

Uncaught TypeError: Util.getQuaternionAngle is not a function
    at ComplementaryFilter.run_ (webvr-polyfill.js:4237)
    at ComplementaryFilter.addGyroMeasurement (webvr-polyfill.js:4190)
    at FusionPoseSensor.updateDeviceMotion_ (webvr-polyfill.js:4039)
    at FusionPoseSensor.onDeviceMotion_ (webvr-polyfill.js:4009)

Steps to reproduce:

  1. Open http://googlevr.github.io/webvr-polyfill/examples/basic/?debug=true in Chrome on Android
  2. Attach a remote Chrome debugger
  3. Click the VR button

It appears that Util.getQuaternionAngle was (accidentally) removed some time after v0.2.6, but it was still used in debug mode. This PR re-adds this missing function.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@MattiasBuelens
Copy link
Contributor Author

@googlebot I signed it

@googlebot
Copy link

CLAs look good, thanks!

@MattiasBuelens
Copy link
Contributor Author

Perhaps off-topic, but what's the value of this debug mode? We accidentally ran into this because a customer was using ?debug for debugging their own website, not the WebVR polyfill. If it's been broken for so long and nobody's actually using it, maybe it's better to remove it altogether?

@jsantell
Copy link
Contributor

jsantell commented Dec 7, 2017

Thanks for reporting this! It seems debug is somewhat vestigial, not one I ever used or dove into since I've started maintaining several months ago.

Long term, I think I'd rather remove this, or make it a value in the configuration, rather than a query param. In the mean time, let's merge this util back in. Thanks for digging into this!

@jsantell jsantell merged commit 1dc3897 into immersive-web:master Dec 7, 2017
@jsantell jsantell mentioned this pull request Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants