Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the latest tag version and append it with "devel" to signify the binary installation via source code #1574

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

CarlJi
Copy link
Member

@CarlJi CarlJi commented Dec 12, 2023

gop version output incorrect tag version if the binary installation via source code as below:

➜  gop git:(main) gop version
gop v1.1.3-577-g4cf8b5e9 darwin/amd64

Now, This behavior will be adjusted to:

➜  gop git:(fix_version) gop version
gop v1.1.13 devel darwin/amd64

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4cf8b5e) 91.32% compared to head (fce5771) 91.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1574   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files          39       39           
  Lines       10239    10239           
=======================================
  Hits         9351     9351           
  Misses        722      722           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiwei xushiwei merged commit 8d774f8 into goplus:main Dec 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants