-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update:support declared function in classfile's overload decl #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
+ Coverage 93.28% 93.29% +0.01%
==========================================
Files 41 41
Lines 11612 11631 +19
==========================================
+ Hits 10832 10851 +19
Misses 623 623
Partials 157 157 ☔ View full report in Codecov by Sentry. |
luoliwoshang
changed the title
[wip] update:support named function in classfile's overload decl
[wip] update:support declared function in classfile's overload decl
May 16, 2024
luoliwoshang
force-pushed
the
overload/classfile
branch
from
May 17, 2024 02:19
a843147
to
9bc8681
Compare
visualfc
reviewed
May 22, 2024
visualfc
reviewed
May 22, 2024
visualfc
reviewed
May 22, 2024
luoliwoshang
force-pushed
the
overload/classfile
branch
5 times, most recently
from
May 22, 2024 09:46
026266e
to
3ef19b3
Compare
luoliwoshang
changed the title
[wip] update:support declared function in classfile's overload decl
update:support declared function in classfile's overload decl
May 22, 2024
visualfc
reviewed
May 22, 2024
visualfc
reviewed
May 22, 2024
luoliwoshang
force-pushed
the
overload/classfile
branch
from
May 22, 2024 12:32
3ef19b3
to
397272d
Compare
visualfc
reviewed
May 22, 2024
luoliwoshang
force-pushed
the
overload/classfile
branch
from
May 22, 2024 12:36
397272d
to
d4c5639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1874
The overloaded function declaration in classfile will eventually become an overloaded method of type classfile
Rect.gox
autogen.go