You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This code doesn't really work. On FreeBSD 10 sys.platform is set to 'freebsd10', and 'freebsd10'.starswith('bsd') is false, so this code always returns PLATFORM_UNKNOWN. As a consequence, the default observer on FreeBSD is the polling-based one, not the kqueue-based one.
Could you change the platform detection to something like the following instead?
Also note that kqueue observer is somewhat broken: it does not create a listener for the top level directory (DirectorySnapshot only lists the children and skips the parent), so if new files are added to it, the observer will not see them. This was not an issue before, because that observer was never used, but if platform detection is to be fixed, the observer should be fixed as well.
Hi. Currently watchdog uses this code to detect current platform:
This code doesn't really work. On FreeBSD 10
sys.platform
is set to'freebsd10'
, and'freebsd10'.starswith('bsd')
is false, so this code always returnsPLATFORM_UNKNOWN
. As a consequence, the default observer on FreeBSD is the polling-based one, not the kqueue-based one.Could you change the platform detection to something like the following instead?
The text was updated successfully, but these errors were encountered: