Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchmedo automatic-restart doesn't terminate child processes when it is terminated #609

Open
Varriount opened this issue Jan 5, 2020 · 3 comments

Comments

@Varriount
Copy link

Currently, watchmedo automatic-restart creates its command in a new process group. Because of this, if watchmedo is terminated (for example, by ctrl+c) the running command will not be terminated.

I can add a new flag the prevents putting the process into a new process group (though I'm wondering why you would want to in the first place). Would this be accepted?

@BoboTiG
Copy link
Collaborator

BoboTiG commented Jan 5, 2020

Related to #225?

@Varriount
Copy link
Author

@BoboTiG Yes, although I don't know why the creator of the original issue had that problem. By default on *nix systems, signals propagate from a parent process to all children in the same process group.

@hholst80
Copy link

Maybe they are running watchmedo as PID 1 in a container?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants